VMware: Deleting an instance might delete Cinder volume's vmdk

[Vipin Balachandran]

If the instance is migrated (manual or SDRS) with an attached volume, the volume's vmdk will end up in instance's datastore folder. In such a case, instance destroy deletes the volume vmdk.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/169282

[Charles V Bock (charles-v-bock)]

Recommend this issue be promoted to High importance due to data-loss potential.

[Vipin Balachandran (vbala)]

The instance deletion is attempted after volume detach.

Steps to reproduce:

* Attach vol-1 to vm-1
* Migrate vm-1(using vSphere client) to a different host and datastore
* Detach vol-1
* Delete vm-1

[OpenStack Infra (hudson-openstack)]

Change abandoned by Joe Gordon (<email address hidden>) on branch: master
Review: https://review.openstack.org/169282
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[Markus Zoeller (markus_z) (mzoeller)]

Solving an inconsistency: The bug is "in progress" but without an assignee.
I set the status back to the last known before the change to "in progress".

Feel free to assign the bug to yourself. If you do so, please set it to "in progress".

[Gary Kotton (garyk)]

https://review.openstack.org/#/c/193103/

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/205819

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/205819
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=6d58a3b980ccec438bcc3c39c70719cc5d8b1f1f
Submitter: Jenkins
Branch: master

commit 6d58a3b980ccec438bcc3c39c70719cc5d8b1f1f
Author: Gary Kotton <email address hidden>
Date: Sun Jul 26 06:30:24 2015 -0700

    VMware: create method for getting datacenter from datastore

    The method previously defined in vmops was factored out to be a
    utility method. This is to enable us to use this in additional
    classes.

    Change-Id: Ia8139a7d0cc95fb3333015470556103914db3cf0
    Related-Bug: #1428645

[OpenStack Infra (hudson-openstack)]

Change abandoned by Michael Still (<email address hidden>) on branch: master
Review: https://review.openstack.org/193103
Reason: This patch has been sitting unchanged for more than 12 weeks. I am therefore going to abandon it to keep the nova review queue sane. Please feel free to restore the change if you're still working on it.