Retry policy break-on property does not work

[Nikolay Makhotkin]

if we define something like

...
task1:
  policies:
    count: 5
    delay: 4
    break-on: <% true %>

it won't break the iteration of retries.

Moreover, there is ambiguity in 'break-on': we don't exactly know what task state will be - SUCCESS or ERROR.

Decided to use 'error-on' and 'success-on' for explicitly changing state.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/161658

[Dmitri Zimine (i-dz)]

Ack the problem.

However the error-on and on-error/ success-on and on-success is too confusing.
We already have people complaining to wait-before and pause-before.

Let's check for better wording and do some user-research/validation before committing it.

[Nikolay Makhotkin (nmakhotkin)]

Any suggestions?

One more option: succeED-on and fail-on, what do tou think?

Or we can even abandon this suffix '-on': success-expr/error-expr.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Nikolay Mahotkin (<email address hidden>) on branch: master
Review: https://review.openstack.org/161658