Floating IP addresses sorting

[Kyrylo Romanenko]

Steps:
1. Navigate to Horizon:
Project -> Compute -> Access & Security -> Floating IPs
2. Allocate IP to Project - several times util all quota will be disposed.
3. Try to Sort IP addresses by clicking on tablesorter-header "IP Address".

Expected to sort IPs ascending and descending.
Actual: sorting does not work at all.

Environment:
Devstack
os|distro=trusty
os|vendor=Ubuntu
os|release=14.04
git|cinder|master[2079b0f]
git|glance|master[8d21220]
git|heat|master[6d6e417]
git|heat-cfntools|master[a7ffb71]
git|heat-templates|master[35e6837]
git|horizon|master[680488d]
git|keystone|master[e54c323]
git|noVNC|master[4e534a8]
git|nova|master[422b22e]
git|rally|master[7683f6b]
git|requirements|master[be0bb7c]
git|tempest|master[fc1593a]
pkg|libxml2-dev|2.9.1+dfsg1-3ubuntu4.4

and MOS build
{"build_id": "2015-03-01_22-54-44", "ostf_sha": "5cc59010fd4db71dc45e87b31ff24325d9a7f28f", "build_number": "153", "release_versions": {"2014.2-6.1": {"VERSION": {"build_id": "2015-03-01_22-54-44", "ostf_sha": "5cc59010fd4db71dc45e87b31ff24325d9a7f28f", "build_number": "153", "api": "1.0", "nailgun_sha": "c2b857b040a2e2121727aa874d0dff1374d6e5ce", "production": "docker", "python-fuelclient_sha": "3ebfa9c14a192d0298ff787526bf990055a23694", "astute_sha": "3a39ae300b8b3b02afbee03ea5116cd5357f8fc5", "feature_groups": ["mirantis"], "release": "6.1", "fuelmain_sha": "baf24424a4e056c6753913de5f8c94851903f718", "fuellib_sha": "510e82f3fd21e45fe757058bf5e658669765f02e"}}}, "auth_required": true, "api": "1.0", "nailgun_sha": "c2b857b040a2e2121727aa874d0dff1374d6e5ce", "production": "docker", "python-fuelclient_sha": "3ebfa9c14a192d0298ff787526bf990055a23694", "astute_sha": "3a39ae300b8b3b02afbee03ea5116cd5357f8fc5", "feature_groups": ["mirantis"], "release": "6.1", "fuelmain_sha": "baf24424a4e056c6753913de5f8c94851903f718", "fuellib_sha": "510e82f3fd21e45fe757058bf5e658669765f02e"}

Looks like regression of very old previously fixed issue: https://bugs.launchpad.net/horizon/+bug/1108085

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/162038

[Kahou Lei (kahou82)]

Hi Chris,

I had this bug fix on my private branch for a while. So I think it will be easier for me to submit a fix.

Let me know if it is ok to you or not.

Thanks!

[Chris Johnson (wchrisjohnson)]

Kahou Lei (kahou82), it's generally considered bad form to reassign a bug that is in-progress. I have actually been debugging this for several hours tonight. Next time, please contact the assignee before reassigning the bug.

[Kahou Lei (kahou82)]

Hi Chris,

Sorry about that. Actually launchpad automatically reassign the assignee to me. It is OK that you can reassign to yourself again and I can abandon my change :).

Thanks.

[Chris Johnson (wchrisjohnson)]

Hi Kahou (kahou82):

I apologize. It looks like you reached out to me around the same time your patch hit. I didn't see message #3 above until tonight. The timing of your patch was just coincidental as I had been trying to isolate the problem for a couple of hours. PLEASE go ahead and follow through with your fix. No need to abandon it, especially since it appears to work. I'll even give you good review. ;-)

Thanks!

[Kahou Lei (kahou82)]

Thanks Chris!

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/162038
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=877e465b367e80619775f77980de7c28517f316b
Submitter: Jenkins
Branch: master

commit 877e465b367e80619775f77980de7c28517f316b
Author: Kahou Lei <email address hidden>
Date: Thu Mar 5 23:08:27 2015 -0800

    Floating IP table should support sorting

    Currently the IPv4Address parser in the tablesort only look up the text inside
    <li></li>. This works fine in the instance table since the cell format has a list to
    wrap around it. However, other table can still fit the IP without <li> with it.

    This patach is to enhance the parser to look up the text in the cell directly if <li>
    is not presented.

    Change-Id: Id22ebc538d6d2adbcb6be21be2f28c47b0fcc217
    Closes-Bug: #1428172

[Denis Kostryukov (dkostryukov)]

The patch doesn't work in MOS 6.1

[Denis Kostryukov (dkostryukov)]

In MOS 6.1 and MOS 7.0, if I try to change sorting direction by clicking to first column (IP) header, sorting not working

[Timur Sufiev (tsufiev-x)]

Kirill, Denis, please do not mix up MOS downstream and Horizon upstream bugs. The standard workflow for MOS Horizon is to create a separate bug for MOS project and then reference there an upstream bug (creating it if needed).