Fuel tries to stop nova-network serivce on compute, while nova-network is not being install on compute node

[Igor Zinovik]

Environment:
 Ubuntu as target OS
 3 controllers
 1 compute
  vCenter enabled

Granular task openstack-network.pp forbids to install nova-network on compute nodes when multi_host mode
for nova-network is set to false (it is set to false due to vCenter). During deployment run vmware-compute.pp
task tries to stop nova-network service and failes because there is no init script for it.

Steps to reproduce:
 1. Create cluster
 2. Enable vCenter
 3. Leave defaults the rest of the settings.
 4. deploy cluster

Expected result:
 Cluster is up and running

Actual result:
 Compute nodes fail to deploy with message:
...
 (/Stage[main]/Main/Service[nova-network]) Could not evaluate: Could not find init script or upstart conf file for 'nova-network'
...

Impact:
 deployment cannot be completed

api: '1.0'
astute_sha: 1be5b9b827f512d740fe907c7ff72486d4030938
auth_required: true
build_id: '37'
build_number: '37'
feature_groups:
- mirantis
fuellib_sha: 0827ca4772e27157fadeaf7ec90c0f2928b5a108
fuelmain_sha: baf24424a4e056c6753913de5f8c94851903f718
nailgun_sha: c7d71dca34d15ac7108a9b75a49f2f6234c944df
ostf_sha: 103d6cf6badd57b791cfaf4310ec8bd81c7a8a46
production: docker
python-fuelclient_sha: 3ebfa9c14a192d0298ff787526bf990055a23694
release: '6.1'
release_versions:
  2014.2-6.1:
    VERSION:
      api: '1.0'
      astute_sha: 1be5b9b827f512d740fe907c7ff72486d4030938
      build_id: '37'
      build_number: '37'
      feature_groups:
      - mirantis
      fuellib_sha: 0827ca4772e27157fadeaf7ec90c0f2928b5a108
      fuelmain_sha: baf24424a4e056c6753913de5f8c94851903f718
      nailgun_sha: c7d71dca34d15ac7108a9b75a49f2f6234c944df
      ostf_sha: 103d6cf6badd57b791cfaf4310ec8bd81c7a8a46
      production: docker
      python-fuelclient_sha: 3ebfa9c14a192d0298ff787526bf990055a23694
      release: '6.1'

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/161193

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/161193
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=66a5de996b320040ebc914a5d42a2eaf3947bdf3
Submitter: Jenkins
Branch: master

commit 66a5de996b320040ebc914a5d42a2eaf3947bdf3
Author: Igor Zinovik <email address hidden>
Date: Wed Mar 4 15:25:27 2015 +0300

    Do not try to stop and reconfigure nova-network on compute nodes

    - vmware-compute task tries to stop nova-network service in vCenter
      enabled environment, but fails dur to service absence because it was not
      installed by
      osnailyfacter/modular/openstack-network/openstack-network.pp
    - remove vmware-compute task from osnailyfacter/vmware/tasks.yaml
    - remove vmware-compute dependency in
      osnailyfacter/modular/openstack-network/tasks.yaml
    - delete osnailyfacter/modular/vmware/vmware-compute.pp

    Change-Id: I8e71d725ce4c55783f19afde11b509a16542c6f4
    Closes-bug: 1428107

[Tatyana Dubyk (tdubyk)]

Verified on 6.1 (#218 iso)