The iscsi_num_targets and iser_num_targets config parameters are not used at iscsi target

Bug #1427904 reported by Mitsuhiro Tanino
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Mitsuhiro Tanino

Bug Description

After introducing new iscsi target driver model via Change-Id: I43190d1dac33748fe55fa00f260f32ab209be656,
configuration parameters of iscsi_num_targets and iser_num_targets are not used from these new scsi targets .

We should remove these unused configuration parameters to avoid confusion for users.

Tags: iscsi target
Changed in cinder:
assignee: nobody → Mitsuhiro Tanino (mitsuhiro-tanino)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/161036

Changed in cinder:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/161036
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=582b4dfc7833f2adfea787cff5bce8e858d80d0e
Submitter: Jenkins
Branch: master

commit 582b4dfc7833f2adfea787cff5bce8e858d80d0e
Author: Mitsuhiro Tanino <email address hidden>
Date: Tue Mar 3 17:49:03 2015 -0500

    Make unused iscsi_num_targets, iser_num_targets configs as deprecated

    After introducing new iscsi target driver model via Change-Id:
    I43190d1dac33748fe55fa00f260f32ab209be656, configuration
    options of iscsi_num_targets and iser_num_targets are not
    used in these new scsi targets.

    This patch makes these unused configuration options as
    deprecated and adds warning messages to notify future removal
    of these configs to users.

    Also this patch removes _ensure_iscsi_targets() which uses these
    two config options from cxt scsi target because this method is
    never called anywhere.

    Closes-Bug: #1427904
    DocImpact: Two unused config options are deprecated
    Change-Id: Ic34910f4765f46e2708de7cb686e49418f486709

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → kilo-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: kilo-3 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.