Slightly able to read notification with Elementary.Dark theme

Bug #1427853 reported by PK
44
This bug affects 7 people
Affects Status Importance Assigned to Milestone
elementary Stylesheet
Fix Released
Medium
Unassigned

Bug Description

Gala notifications after switching theme to dark are difficult to read. Text of notification is black (#333) and background is dark also. I suggest add new rule in CSS to change text color to white (i.e. nicely done in @swnh's Orchis theme - http://postimg.org/image/qbyfznf11/).

Related branches

Revision history for this message
PK (pk1111) wrote :
Revision history for this message
Danielle Foré (danrabbit) wrote :

I don't support forcing apps to use the dark theme.

Changed in egtk:
status: New → Won't Fix
Revision history for this message
PK (pk1111) wrote :

I don't really get it what did you mean when you said "forcing apps". It always is black on dark, it doesn't matter what program I use - notify-send, midori or terminal when command was successfully completed.

Revision history for this message
Danielle Foré (danrabbit) wrote :

Notifications are white in the default install. I'm guessing you're forcing the entire system to use the dark theme. I don't support that. There are other themes that are only dark. This theme has two halves that compliment each other. They are not intended to replace each other.

Revision history for this message
Ash (ash1991) wrote :

This fixes it. (the apps.css is provided by `elementary-theme` and is located at /usr/share/themes/elementary/gtk-3.0/)
Hope it'll get merged.

--- apps.css 2015-05-09 05:38:38.000000000 +0430
+++ apps.css 2015-05-16 10:54:53.199151000 +0430
@@ -116,14 +116,18 @@
                                   alpha (@bg_color, 0.98) 80%,
                                   alpha (shade(@bg_color, 0.94), 0.98)
                                   );
- box-shadow: inset 0 0 0 1px alpha (#fff, 0.10),
- inset 0 1px 0 0 alpha (#fff, 0.90),
- inset 0 -1px 0 0 alpha (#fff, 0.30),
+ box-shadow: inset 0 0 0 1px alpha (@base_color, 0.10),
+ inset 0 1px 0 0 alpha (@base_color, 0.90),
+ inset 0 -1px 0 0 alpha (@base_color, 0.30),
                 0 0 0 1px alpha (#000, 0.20),
                 0 3px 6px alpha (#000, 0.16),
                 0 3px 6px alpha (#000, 0.23);
 }

+.gala-notification .title, .gala-notification .label {
+ color: @text_color;
+}
+
 .gala-button {
     padding: 3px;
     color: #fff;

Revision history for this message
Ash (ash1991) wrote :
Revision history for this message
Danielle Foré (danrabbit) wrote :

Ash, please create a merge request so your code can go through review

Revision history for this message
Ash (ash1991) wrote :

Dan, Actually I'm not a dev and I haven't worked with launchpad that much (as a dev) so would you mind taking care yourself?

Changed in egtk:
milestone: none → loki-beta1
status: Won't Fix → Fix Committed
Changed in egtk:
milestone: loki-beta1 → loki-alpha1
Cody Garver (codygarver)
Changed in egtk:
importance: Undecided → Medium
Cody Garver (codygarver)
Changed in egtk:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.