hold summary count/"Ready for pickup" holds list status do not always match

[Chris Sharp]

Discovered from a PINES Helpdesk ticket. The original report was that there was a hold in the list of holds showing "Ready for pickup", but the summary count showed 0 holds ready for pickup. Quoting from my response to the Helpdesk ticket:

The hold summary count differs from the actual list of holds in the way that it considers items to be available for pickup. The summary count says:

1) if the hold belongs to this user and
2) has not been fulfilled or canceled and
3) the pickup library matches the current shelf library,

consider the hold to be available.

The holds list logic says:

1) if the hold is not canceled or frozen
2) and if there is a current shelf library set, that the current shelf library matches the pickup library, and
3) there is a current copy assigned to the hold, and
4) the hold has been captured, and
5) the copy status is not "In transit", and
6) the copy status is "On holds shelf", and
7) the current time is past the configured hold shelf status delay (if configured)

then consider the copy "Ready for pickup".

So because there is no current shelf library set, the holds summary count sees that the current shelf library doesn't match the pickup library and therefore doesn't consider the copy to be ready for pickup. The holds list logic skips that test because there isn't a current shelf library set.

Evergreen 2.7.2
PostgreSQL 9.3
Ubuntu 12.04/14.04
OpenSRF 2.4

[Michele Morgan (mmorgan)]

Confirmed that this is still true in 3.6. A hold without a current_shelf_lib still displays as Ready for Pickup, but is not included in the Summary count.

Additionally, an item that shows Hold Shelf Status Delay in the details is included in the Ready for Pickup summary count.

[Terran McCanna (tmccanna)]

See also: bug 1959405 which changes the behavior for the text that displays when there is a hold shelf delay, but it does not resolve the count issue when there is a hold shelf delay.