Oversight when copying configdrive during live migration on Hyperv

[Adelina Tuvenie]

When fixing bug https://launchpad.net/bugs/1322096 there was an oversight. When copying the iso we check if the instance requires a config drive and if that config drive is a iso, by checking the value "config_drive_cdrom" from the conf. This value can change and thus, even if the instance has a iso configdrive attached it will be ommitted in the way the fix was implemented.

A better idea would be to check if the instance has a attached iso.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/160751

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/160751
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=56a6c6485d197eb15c3bdf421c5580c6dc29f816
Submitter: Jenkins
Branch: master

commit 56a6c6485d197eb15c3bdf421c5580c6dc29f816
Author: Adelina Tuvenie <email address hidden>
Date: Tue Mar 3 02:36:24 2015 -0800

    Fix copy configdrive during live-migration on HyperV

    This bug was introduced due to an oversight when fixing
    https://launchpad.net/bugs/1322096 . In that fix, we use the
    "config_drive_cdrom" value from the conf to determine if a
    there is a iso configdrive attached to the instance. This
    approach is wrong due to the fact that that config value can be
    modified by the user. If that happens, instances that still have
    iso configdrives will be ommitted.

    This path fixes this problem by checking the instance itself if
    it has any iso attached to it.

    Closes-Bug: #1427467
    Change-Id: Ia64389b4405109d7db6fbf9c000a0136e9862298