Patrons with all transactions paid crash open-ils.collections.user_balance_summary.generate

[Jason Boyer]

Evergreen: 2.7.2 and older
Other versions: N/A

If a patron in collections pays off all of their bills (the ideal situation!) they will break the generation of any user balance summary file that they should appear in until they're removed from the collections tracker table.

In Collections.pm sub user_balance_summary the balance of all open transactions is requested via a json_query against money.billable_transaction_summary. If there are no open transactions for the current user then the ids parameter is blank and when the SQL is built it has an empty IN clause, aborting the processing of the current user and the entire file. To prevent this, the array of transaction ids needs to be checked to verify there's at least one transaction to return a value for.

[Jason Boyer (jboyer)]

Branch with a fix is available here: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jboyer/lp_1427309_collections_user_summary

[Jason Boyer (jboyer)]

I forgot to mention, Evergreen Indiana is running this in production and we've been in contact with a collections vendor that could not retrieve full balances before and can now.

I don't personally know how to trigger the file generation, so I've been unable to test it directly. I can see the results of their now successful runs in /openils/var/web/collections/, however.

[Bill Erickson (berick)]

Confirmed the bug and confirmed the patch resolves the issue. Pushed to 2.6+. Thanks, Jason.