Flight mode test doesn't unlock sim after disabling flight mode

[Richard Huddie]

If the flight mode test is run on a device with sim pin lock enabled, the sim does not get unlocked after the tests has completed and flight mode has been disabled.

This means that after unity8 is stopped and restarted for the next test to run, it is stuck on the sim pin entry screen. This means that all subsequent tests will fail.

If any of the sims are pin locked then the flight mode test should include cleanup actions that unlock the sims again after turning flight mode off.

[Vincent Ladeuil (vila)]

I ran into the same issue.
Not all tests fail when a sim card has a pin code, only some.

I agree the fix would be to detect whether the sim is already locked or not and restore its state during the tear down.

[Vincent Ladeuil (vila)]

There is an isolation issue between the ubuntu_sanity_tests.tests.test_sim_pin.SimPinTestCase.test_sim_pin_lock_and_unlock and ubuntu_sanity_tests.tests.test_flight_mode.FlightModeTestCase.test_switching_on_flight_mode_must_engage_flight_mode

While the former works whether SIM is initially locked or not, the later make othe tests fail if the SIM is initially locked.

https://bugs.launchpad.net/ubuntu-sanity-tests/+bug/1408727 took care about the SIM test may be some code can be re-used.