EmbeddedImage::prepare_embedded_images() - Undefined variable: form

[Ghada El-Zoghbi]

Mahara: 15.04dev
OS: Linux
DB: postgres, mysql
browser: any

The function EmbeddedImage::prepare_embedded_images() in htdocs/lib/embeddedimage.php has 2 undefined variables:

$form and $element

on line 61.

[WAR] 62 (lib/embeddedimage.php:61) Undefined variable: form
Call stack (most recent first):

    log_message("Undefined variable: form", 8, true, true, "/var/www/maharacode/mahara/htdocs/lib/embeddedimag...", 61) at /var/www/maharacode/mahara/htdocs/lib/errors.php:441
    error(8, "Undefined variable: form", "/var/www/maharacode/mahara/htdocs/lib/embeddedimag...", 61, array(size 20)) at /var/www/maharacode/mahara/htdocs/lib/embeddedimage.php:61
    EmbeddedImage::prepare_embedded_images("<p>aaaa&nbsp;<img src="http://d.general.mahara/art...", "post", 2, "1") at /var/www/maharacode/mahara/htdocs/interaction/forum/editpost.php:198
    editpost_submit(object(Pieform), array(size 7)) at Unknown:0
    call_user_func_array("editpost_submit", array(size 2)) at /var/www/maharacode/mahara/htdocs/lib/pieforms/pieform.php:532
    Pieform->__construct(array(size 4)) at /var/www/maharacode/mahara/htdocs/lib/pieforms/pieform.php:162
    Pieform::process(array(size 4)) at /var/www/maharacode/mahara/htdocs/lib/pieforms/pieform.php:71
    pieform(array(size 4)) at /var/www/maharacode/mahara/htdocs/interaction/forum/editpost.php:173

It can be reproduced by:

- Create a group and enter a new topic in the forum.
- As a regular user - not the owner of the group - create a reply (with an image) to the topic
- As the owner of the group, edit the reply.
- above error will be generated.

[Son Nguyen (ngson2000)]

I marked it high as it is related to the patch https://reviews.mahara.org/#/c/4124

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/4382

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/4382
Committed: http://gitorious.org/mahara/mahara/commit/5c68436247b8fedd51725468fbb5dbfe00e55725
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 5c68436247b8fedd51725468fbb5dbfe00e55725
Author: Son Nguyen <email address hidden>
Date: Fri Mar 13 09:22:07 2015 +1300

Strip out unnecessary $form and $element. Bug 1427027

Change-Id: I07615cbbee5914b2affb5b26edc69d64539f6a2c