SQLConnectionIDs bug in ZSQLMethods Product

[Jan Wijbrand Kolman]

The SQL.py module in the ZSQLMetohds Product provides a method to list all availble SQL Connections. It's purpose, or so it seems, is to return a list of tuples, where the first item in the tuple is the connection's title (if available) and the second item the connection's id.

However, in constructing the the list of tuple, a dictionary is used with the connection id for key *and* the id for value - the connection's title is never used.

I'd propose this patch:

 $ diff SQL.py SQL-patched.py
 40,42c40,44
 < if hasattr(o,'title_and_id'): o=o.title_and_id()
 < else: o=id
 < ids[id]=id
 ---
 > if hasattr(o,'title_and_id'):
 > title = o.title_and_id()
 > else:
 > title = id
 > ids[id] = title

[Hanno Schlichting (hannosch)]

Still true in Zope trunk.

[Jens Vagelpohl (dataflake-deactivatedaccount-deactivatedaccount)]

Fix committed in http://svn.zope.org/?rev=115792&view=rev, will appear in version 2.13.3

[Colin Watson (cjwatson)]

The products.zsqlmethods project on Launchpad has been archived at the request of the Zope developers (see https://answers.launchpad.net/launchpad/+question/683589 and https://answers.launchpad.net/launchpad/+question/685285). If this bug is still relevant, please refile it at https://github.com/zopefoundation/products.zsqlmethods.