fuel-menu doesn't warn when an IP address already exists

[Andrey Danin]

Reproduced on MOS 6.0 GA.
  feature_groups:
    - mirantis
  production: "docker"
  release: "6.0"
  api: "1.0"
  build_number: "58"
  build_id: "2014-12-26_14-25-46"
  astute_sha: "16b252d93be6aaa73030b8100cf8c5ca6a970a91"
  fuellib_sha: "fde8ba5e11a1acaf819d402c645c731af450aff0"
  ostf_sha: "a9afb68710d809570460c29d6c3293219d3624d4"
  nailgun_sha: "5f91157daa6798ff522ca9f6d34e7e135f150a90"
  fuelmain_sha: "81d38d6f2903b5a8b4bee79ca45a54b76c1361b8"

When installing Fuel Master node and there is another server with the same IP (10.20.0.2 for example) in Fuel PXE network, fuel-menu doesn't warn about it. Fuel-menu applies network settings but after that some of fields remain empty (see an attached screenshot).

Steps to reproduce:
1. Connect two nodes to the same vlan (or bridge in Linux/libvirt).
2. Run Linux on the first one and set its IP address to 10.20.0.2/24.
3. Stat to install Fuel to the second node. Set "showmenu=yes" in bootloader config.
4. Wait until Fuel-menu appears.
5. Check that in Network Settings no IP/Netmask/Gateway information exist (but it should be there).
6. Fill it with standard values (10.20.0.2/24 and .1 as GW) and apply them.

Expected result:
Some warning should appear.

Actual result:
Fuel-menu reports that "Changes successfully applied" but IP settings stay empty in interface section.

As fuel-menu uses L23network Puppet module to configure interfaces, it may be bug in it.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/170844

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/170844
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=f9d9c89d8a943cecceda2102adbcdd73397ef158
Submitter: Jenkins
Branch: master

commit f9d9c89d8a943cecceda2102adbcdd73397ef158
Author: Matthew Mosesohn <email address hidden>
Date: Mon Apr 6 14:29:14 2015 +0300

    Add duplicate IP address check to fuelmenu

    Fail check on Fuel Setup if duplicate host found
    on the same IP address.

    Change-Id: Ib05a5632702789203338774b96992e05f1a7978d
    Closes-Bug: #1426573

[Emma Gordon (emma-0)]

I took the fuel community build ISO from the 10th April and found that any changes I made in network setup were thrown away when I tried to apply them despite reporting "Changes successfully applied". I then took the 12-41-44 build from the 6th April and found that network setup changes worked fine. I suspect the above checkin in this area on the 7th April may be the culprit.

[Matthew Mosesohn (raytrac3r)]

Emma, can you attach your /var/log/fuelmenu.log for more details?

[Emma Gordon (emma-0)]

I no longer have a setup with the 10th April community build, but I'm seeing the same issue with this ISO that I was directed to use instead: http://bffa.ru/fuel-6.1-307-2015-04-12_12-50-24.iso

Contents of /var/log/fuelmenu.log:

2015-04-17 14:30:07,642 DEBUG No DHCP servers found
2015-04-17 14:30:09,985 INFO loading module ntpsetup
2015-04-17 14:30:10,013 WARNING No setting named ntpenabled found.
2015-04-17 14:30:10,013 INFO loading module dnsandhostname
2015-04-17 14:30:10,073 WARNING No setting named TEST_DNS found.
2015-04-17 14:30:30,192 INFO loading module servicepws
2015-04-17 14:30:30,219 INFO loading module saveandquit
2015-04-17 14:30:30,229 INFO loading module cobblerconf
2015-04-17 14:30:30,258 DEBUG Old settings OrderedDict([('HOSTNAME', 'fuel'), ('DNS_DOMAIN', 'domain.tld'), ('DNS_SEARCH', 'domain.tld'), ('DNS_UPSTREAM', '8.8.8.8'), ('NTP1', '0.pool.ntp.org'), ('NTP2', '1.pool.ntp.org'), ('NTP3', '2.pool.ntp.org'), ('ADMIN_NETWORK', OrderedDict([('interface', 'eth0'), ('ipaddress', '10.20.0.2'), ('netmask', '255.255.255.0'), ('cidr', '10.20.0.0/24'), ('size', '256'), ('dhcp_pool_start', '10.20.0.3'), ('dhcp_pool_end', '10.20.0.254'), ('mac', '00:50:56:92:08:7b'), ('dhcp_gateway', '10.20.0.2')])), ('FUEL_ACCESS', OrderedDict([('user', 'admin'), ('password', 'admin')])), ('postgres', OrderedDict([('keystone_dbname', 'keystone'), ('nailgun_user', 'nailgun'), ('keystone_user', 'keystone'), ('nailgun_password', 'QF10J6LY'), ('ostf_user', 'ostf'), ('nailgun_dbname', 'nailgun'), ('keystone_password', 'ecGCG6BI'), ('ostf_dbname', 'ostf'), ('ostf_password', 'I69udMhu')])), ('cobbler', OrderedDict([('password', 'yKmxQoar'), ('user', 'cobbler')])), ('astute', OrderedDict([('password', 'cGNAdqhu'), ('user', 'naily')])), ('keystone', OrderedDict([('nailgun_user', 'nailgun'), ('monitord_user', 'monitord'), ('nailgun_password', 'psALLCdx'), ('monitord_password', 'lPzO8dgb'), ('ostf_user', 'ostf'), ('admin_token', '4vtrpajP'), ('ostf_password', 'JRezRhCX')])), ('mcollective', OrderedDict([('password', 'BxiyxNcl'), ('user', 'mcollective')]))])
2015-04-17 14:30:30,258 INFO loading module shell
2015-04-17 14:30:30,259 INFO loading module interfaces
2015-04-17 14:30:30,269 INFO init Interfaces
2015-04-17 14:30:30,278 INFO loading module fueluser
2015-04-17 14:30:30,303 WARNING No setting named CONFIRM_PASSWORD found.
2015-04-17 14:30:30,303 INFO loading module rootpw
2015-04-17 14:30:30,336 DEBUG Preparing screen UI for Network Setup
2015-04-17 14:30:30,338 DEBUG Preparing screen UI for Quit Setup
2015-04-17 14:30:30,338 DEBUG Preparing screen UI for Service Passwords
2015-04-17 14:30:30,340 DEBUG Preparing screen UI for Shell Login
2015-04-17 14:30:30,340 DEBUG Preparing screen UI for Fuel User
2015-04-17 14:30:30,340 DEBUG Preparing screen UI for Root Password
2015-04-17 14:30:30,341 DEBUG Preparing screen UI for Time Sync
2015-04-17 14:30:30,342 INFO refresh. gateway is 10.20.0.1
2015-04-17 14:30:30,342 DEBUG Preparing screen UI for DNS & Hostname
2015-04-17 14:30:30,343 DEBUG Preparing screen UI for PXE Setup
2015-04-17 14:30:30,352 DEBUG bootproto for {'addr': '10.20.0.2', 'mac': '00:50:56:92:08:7b', 'broadcast': '10.20.0.255', 'netmask': '2...

[Maksym Strukov (unbelll)]

{"build_id": "2015-04-20_07-52-58", "ostf_sha": "4bab9b975ace8d9a305d6e0f112b734de587f847", "build_number": "323", "release_versions": {"2014.2-6.1": {"VERSION": {"build_id": "2015-04-20_07-52-58", "ostf_sha": "4bab9b975ace8d9a305d6e0f112b734de587f847", "build_number": "323", "api": "1.0", "nailgun_sha": "5a4556ea0cf943edffa33788994b7fb7abe150b3", "openstack_version": "2014.2-6.1", "production": "docker", "python-fuelclient_sha": "b4f1ddffd5263489090b65e662173e9e11aafd94", "astute_sha": "bf1751a4fe0d912325e3b4af629126a59c1b2b51", "feature_groups": ["mirantis"], "release": "6.1", "fuelmain_sha": "991fa8feca4afcf05ce85a1e7ebd7c7503b3f212", "fuellib_sha": "36f30ae7f19092a61eebb0522ca20d27468b4cbf"}}}, "auth_required": true, "api": "1.0", "nailgun_sha": "5a4556ea0cf943edffa33788994b7fb7abe150b3", "openstack_version": "2014.2-6.1", "production": "docker", "python-fuelclient_sha": "b4f1ddffd5263489090b65e662173e9e11aafd94", "astute_sha": "bf1751a4fe0d912325e3b4af629126a59c1b2b51", "feature_groups": ["mirantis"], "release": "6.1", "fuelmain_sha": "991fa8feca4afcf05ce85a1e7ebd7c7503b3f212", "fuellib_sha": "36f30ae7f19092a61eebb0522ca20d27468b4cbf"}

Still can reproduce (with original steps)

[Matthew Mosesohn (raytrac3r)]

Emma, now I understand your issue. It warns for PXE interface only, but it should warn for static configuration of a network interface. I'll make a new patch to cover this case as well.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/176916

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/177353

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/176916
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=2a4160aff786f725dd7a222a9e210fbc2ad72acb
Submitter: Jenkins
Branch: master

commit 2a4160aff786f725dd7a222a9e210fbc2ad72acb
Author: Matthew Mosesohn <email address hidden>
Date: Thu Apr 23 19:52:37 2015 +0300

    Add duplicate IP check when configuring interfaces

    Fuelmenu will now test for duplicate IP when trying to
    allocate a static IP address (was just for PXE Setup
    previously). It will fail before applying any changes
    if it detects another host with the same IP address.

    Change-Id: I27f3e9eee85b7a380a79ec0336113a7f6a2c35e7
    Closes-Bug: #1426573

[OpenStack Infra (hudson-openstack)]

Change abandoned by Matthew Mosesohn (<email address hidden>) on branch: master
Review: https://review.openstack.org/177353
Reason: no longer needed

[Maksym Strukov (unbelll)]

Verified as fixed in 6.1-464

[Vitaly Sedelnik (vsedelnik)]

Won't Fix for 6.0-updates as there is no delivery channel for Fuel fixes in 6.0 updates