iscsi_ip_address is not used by lioadm iscsi_helper

[Gorka Eguileor]

lioadm helper has fixed IP address 0.0.0.0 for portals instead of using iscsi_ip_address from the configuration as it should.

To reproduce:
1. Set iscsi_ip_address option to a specific IP on the node
2. Run targetcli ls and check the portal IP, which will be
  | o- portals .................................................................................................... [Portals: 1]
  | o- 0.0.0.0:3260 ..................................................................................................... [OK]

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/161209

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/161209
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=3abc1d2f63730638abc0344989ccb277b8212642
Submitter: Jenkins
Branch: master

commit 3abc1d2f63730638abc0344989ccb277b8212642
Author: Gorka Eguileor <email address hidden>
Date: Wed Mar 4 14:24:25 2015 +0100

    Create iSCSI lio portals with right IPs and port

    Currently lioadm helper creates portals with fixed IP addresses 0.0.0.0
    and ::0 and also uses fixed standard port 3260 instead of using store
    configuration (iscsi_ip_address, iscsi_secondary_ip_addresses,
    iscsi_port) from the configuration as it should.

    This could lead to problems if a different port was defined in the
    configuration as the target would be available only on 3260 and other
    services would look for it at configured port.

    With this fix we now create the right portals with the right port.

    Since now we pass list of ips and port to helpers cxt helper has also
    been updated to use these parameters instead of going directly to the
    configuration.

    Change-Id: I77e8865b1f015a9fa155f2b4552a5d9c27f5e122
    Closes-Bug: #1425875

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/187666

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/187666
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=ea9e2e00d859a05596d45bb1733b9e79135c6162
Submitter: Jenkins
Branch: stable/kilo

commit ea9e2e00d859a05596d45bb1733b9e79135c6162
Author: Gorka Eguileor <email address hidden>
Date: Wed Mar 4 14:24:25 2015 +0100

    Create iSCSI lio portals with right IPs and port

    Currently lioadm helper creates portals with fixed IP addresses 0.0.0.0
    and ::0 and also uses fixed standard port 3260 instead of using store
    configuration (iscsi_ip_address, iscsi_secondary_ip_addresses,
    iscsi_port) from the configuration as it should.

    This could lead to problems if a different port was defined in the
    configuration as the target would be available only on 3260 and other
    services would look for it at configured port.

    With this fix we now create the right portals with the right port.

    Since now we pass list of ips and port to helpers cxt helper has also
    been updated to use these parameters instead of going directly to the
    configuration.

    Change-Id: I77e8865b1f015a9fa155f2b4552a5d9c27f5e122
    Closes-Bug: #1425875
    (cherry picked from commit 3abc1d2f63730638abc0344989ccb277b8212642)
    Conflicts:
     cinder/cmd/rtstool.py
     cinder/tests/targets/test_cxt_driver.py
     cinder/tests/targets/test_iet_driver.py
     cinder/tests/targets/test_lio_driver.py
     cinder/tests/unit/targets/targets_fixture.py