Empty window - Unhandled exception errors

[Alan Horkan]

Testing with pre 1.6.0
https://dl.dropboxusercontent.com/u/1481774/pinta-dev-1.6.0.0.exe

To reproduce,
Close all documents

Then choose Magic Wand Select from the Tools palette

Unhandled exception error

System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.InvalidOperationException: Tried to get WorkspaceManager.ActiveDocument when there are no open Documents. Check HasOpenDocuments first.
   at Pinta.Core.WorkspaceManager.get_ActiveDocument() in c:\Users\Jonathan\Documents\Pinta\Pinta.Core\Managers\WorkspaceManager.cs:line 64
   at Pinta.Tools.MagicWandTool.OnBuildToolBar(Toolbar tb) in c:\Users\Jonathan\Documents\Pinta\Pinta.Tools\Tools\MagicWandTool.cs:line 58
   at Pinta.Core.BaseTool.DoBuildToolBar(Toolbar tb) in c:\Users\Jonathan\Documents\Pinta\Pinta.Core\Classes\BaseTool.cs:line 134
   at Pinta.Core.ToolManager.SetCurrentTool(BaseTool tool) in c:\Users\Jonathan\Documents\Pinta\Pinta.Core\Managers\ToolManager.cs:line 150
   at Pinta.Core.ToolManager.HandlePbToolItemClicked(Object sender, EventArgs e) in c:\Users\Jonathan\Documents\Pinta\Pinta.Core\Managers\ToolManager.cs:line 94
   --- End of inner exception stack trace ---
   at System.RuntimeMethodHandle._InvokeMethodFast(IRuntimeMethodInfo method, Object target, Object[] arguments, SignatureStruct& sig, MethodAttributes methodAttributes, RuntimeType typeOwner)
   at System.RuntimeMethodHandle.InvokeMethodFast(IRuntimeMethodInfo method, Object target, Object[] arguments, Signature sig, MethodAttributes methodAttributes, RuntimeType typeOwner)
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture, Boolean skipVisibilityChecks)
   at System.Delegate.DynamicInvokeImpl(Object[] args)
   at GLib.Signal.ClosureInvokedCB(Object o, ClosureInvokedArgs args)
   at GLib.SignalClosure.Invoke(ClosureInvokedArgs args)
   at GLib.SignalClosure.MarshalCallback(IntPtr raw_closure, IntPtr return_val, UInt32 n_param_vals, IntPtr param_values, IntPtr invocation_hint, IntPtr marshal_data)

[Alan Horkan (horkana)]

Downloaded 1.6.0.160 zip from Pinta Forge
http://forge.pinta-project.com/

the toolbox seems stable
can't trigger unhandled exception anymore.

[Alan Horkan (horkana)]

Still with 1.6.0.160
found other unhandled exceptions

Various menu items are not disabled and if you click
Layer, Delete layer
Layer, Merge Down
or
Image, Flatten

you get unhandled exception errors.

In the layers palette the buttons for
Delete layer
Merge Down
Move Down
have also not been disabled and cause unhandled exception errors.

[Cameron White (cameronwhite91)]

For me, all of those menu items are disabled if I don't have any open documents.

[Alan Horkan (horkana)]

Stranger and stranger.
I've looked at it again and I'm still seeing it in 1.6.0.160

Clearly there was some intermediate step that I didn't realise was making a difference. This time I was able to reproduce this repeatedly.

This time I opened an image, hit the duplicate layer button, then closed the image without saving.

The menu items are not disabled and cause the exceptions.

[Cameron White (cameronwhite91)]

Fixed: https://github.com/PintaProject/Pinta/commit/5f0afbb7566db18e73bee86f289ebed2df150ac0

[Alan Horkan (horkana)]

Pinta Version 1.7.0.127

Mostly fixed but the move layer down button in the Layers dialog can still cause an exception

[Alan Horkan (horkana)]

previous comment should have said Layers palette (there's no Move Layer Down button in the Layers dialog)

[Cameron White (cameronwhite91)]

Should be fixed by https://github.com/PintaProject/Pinta/commit/99b3199a5e6620489d292d7d2dedf778104ac0bf