dns-exception-handling

[Sriram]

Currently the only way to catch DNS Exception, is to directly look for the error message under the error detail, of the responders dictionary. This should be changed to explicit catch the exception, or create a different key under responders dictionary to include the type of the Exception (eg: callable to Custom Exception Class).

[Sriram (thesriram)]

{u'syslog_severity_code': 4, u'severity': u'WARNING', u'tags': [u'syslog'], u'timestamp': u'Jun 26 19:48:37', u'@timestamp': u'2015-06-26T19:48:37.094Z', u'syslog_facility': u'local0', u'syslog_severity': u'warning', u'program': u'poppy', u'message': u'Job execution failed (consumption proceeding): ZookeeperJob create_service-3a1abd01-da2a-4f4e-8046-17640e6ca1df (9f0c4794-b2e6-4078-b0a1-273e980ef8e7): {u\'store\': {u\'service_id\': u\'9b787bc0-c442-4ce3-888a-be0e52ba95e9\', u\'auth_token\':u\'xx\', u\'project_id\': u\'xx\', u\'providers_list_json\': u\'["akamai"]\', u\'time_seconds\': [22, 44, 88, 176, 352]}}#012Traceback (most recent call last):#012 File "/srv/poppy/local/lib/python2.7/site-packages/taskflow/conductors/backends/impl_blocking.py", line 105, in _dispatch_job#012 engine.run()#012 File "/srv/poppy/local/lib/python2.7/site-packages/taskflow/engines/action_engine/engine.py", line 125, in run#012 for _state in self.run_iter():#012 File "/srv/poppy/local/lib/python2.7/site-packages/taskflow/engines/action_engine/engine.py", line 183, in run_iter#012 failure.Failure.reraise_if_any(failures.values())#012 File "/srv/poppy/local/lib/python2.7/site-packages/taskflow/types/failure.py", line 302, in reraise_if_any#012 failures[0].reraise()#012 File "/srv/poppy/local/lib/python2.7/site-packages/taskflow/types/failure.py", line 309, in reraise#012 six.reraise(*self._exc_info)#012 File "/srv/poppy/local/lib/python2.7/site-packages/taskflow/engines/action_engine/executor.py", line 67, in _execute_task#012 result = task.execute(**arguments)#012 File "/srv/poppy/local/lib/python2.7/site-packages/poppy/distributed_task/taskflow/task/create_service_tasks.py", line 84, in execute#012 raise Exception(msg)#012Exception: Create DNS for Akamai failed!', u'syslog_pri': u'132', u'@version': u'1', u'syslog_facility_code': 16}

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/200282

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/200282
Committed: https://git.openstack.org/cgit/stackforge/poppy/commit/?id=6e4070366af0823dcdf9af998d09bf5e22788a1b
Submitter: Jenkins
Branch: master

commit 6e4070366af0823dcdf9af998d09bf5e22788a1b
Author: Sriram Madapusi Vasudevan <email address hidden>
Date: Thu Jul 9 17:54:02 2015 -0400

    fix: only retry on appropriate dns exceptions per dns driver

    Change-Id: I02b546c4eb7c7069d95906d1458b74e9832fb44f
    Closes-Bug: 1425556