Invalid ICMP type/code in security group rule test

[Tong Liu]

In security group rule with ICMP type and code test, it uses a pair (2, 3) that is not supported in ICMP specification.

Per ICMP specification: http://www.iana.org/assignments/icmp-parameters/icmp-parameters.xhtml, the type 2 is unassigned. We should add other more meaningful type/code combinations into the test such as
- ICMP Echo Request
- ICMP Echo Reply

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/158928
Committed: https://git.openstack.org/cgit/openstack/tempest/commit/?id=ec20aeb90f79ada14d22341455fd447ee8bdc01f
Submitter: Jenkins
Branch: master

commit ec20aeb90f79ada14d22341455fd447ee8bdc01f
Author: Tong Liu <email address hidden>
Date: Wed Feb 25 00:14:35 2015 +0000

    Fix ICMP code/type in security group rule test

    Security group rule with ICMP protocol has type/code fields which
    should follow ICMP specification. Remove the ones that are invalid
    and add more meaningful type/code values.
        - Echo Request (type 8, code 0)
        - Echo Response (type 0, code 0)
        - Time Exceeded (type 11, code None)

    Change-Id: Ia82193eca71f97581e11badd545ac28236f68f85
    Closes-bug: #1425328