SMBFS: fail to retrieve volume path

[Lucian Petrut]

The SMBFS drivers use the image format in order to construct the according image path as some image formats require having the proper extension.

The format is either retrieved using qemu-img if the image exists, either via extra specs or config options if the image does not exist.

The issue is that the extension is not used when searching for local images, falling back to extra specs (which can cause lazy load errors) or config options, which might change after the volume is created.

This issue occurs when vhd/x images are used and particularly affects the volume delete operation. The fix consists in simply using the possible extensions when trying to find existing images.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/159528

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/159528
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=c2b0f8680a2526cd890c55ebaaa1efc06b94dfef
Submitter: Jenkins
Branch: master

commit c2b0f8680a2526cd890c55ebaaa1efc06b94dfef
Author: Lucian Petrut <email address hidden>
Date: Tue Feb 17 16:20:56 2015 +0200

    SMBFS: Fix retrieving the volume path and format

    The SMBFS drivers use the image format in order to construct the
    according image path, as some image formats require having the
    proper extension.

    The format is either retrieved using qemu-img if the image exists,
    either via extra specs or config options otherwise.

    The issue is that when searching for local images, the extension is
    not used, falling back to extra specs, which can cause lazy load
    errors or config options, which might change.

    This issue occurs when vhd/x images are used. The fix consists in
    simply using the possible extensions when trying to find existing
    images.

    Change-Id: I85ef7862489eb434a00cd897f5344bb89b7de858
    Closes-bug: #1425124