Powerpoint with unicode characters makes OpenLP crash
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenLP |
Fix Released
|
Low
|
Tomas Groth |
Bug Description
The traceback below was reported on the support system. The problem is that if a PPT contains unicode characters we get into problems when we save the slide notes and titles to a text file, because python on windows defaults to encode in cp1252. The fix is to use utf-8 encoding when saving the text files.
*OpenLP Bug Report*Version: {'version': '2.1.2', 'build': None, 'full': '2.1.2'}
--- Details of the Exception. ---
Uploading a presentation file. MS Power Point.
--- Exception Traceback
---Traceback (most recent call last): File
D:\OpenLP_
line 321, in on_file_click File
D:\OpenLP_
line 377, in validate_and_load File
D:\OpenLP_
line 186, in load_list File
D:\OpenLP_
line 133, in load_presentation File
D:\OpenLP_
line 410, in create_
D:\OpenLP_
line 335, in save_titles_
c:\Python33\
encodeUnicodeEn
'\uf04a' in position 11: character maps to <undefined>
Related branches
- Tim Bentley: Approve
- Raoul Snyman: Approve
-
Diff: 441 lines (+114/-39)15 files modifiedopenlp/core/ui/formattingtagcontroller.py (+2/-2)
openlp/core/ui/servicemanager.py (+1/-1)
openlp/core/ui/slidecontroller.py (+2/-2)
openlp/plugins/alerts/lib/alertsmanager.py (+2/-2)
openlp/plugins/bibles/lib/opensong.py (+2/-2)
openlp/plugins/bibles/lib/osis.py (+6/-5)
openlp/plugins/bibles/lib/zefania.py (+4/-3)
openlp/plugins/presentations/lib/mediaitem.py (+13/-4)
openlp/plugins/presentations/lib/presentationcontroller.py (+6/-6)
openlp/plugins/presentations/presentationplugin.py (+1/-1)
openlp/plugins/songs/lib/importers/worshipassistant.py (+2/-2)
openlp/plugins/songs/lib/importers/zionworx.py (+2/-2)
scripts/translation_utils.py (+41/-0)
tests/functional/openlp_plugins/presentations/test_mediaitem.py (+24/-1)
tests/functional/openlp_plugins/presentations/test_presentationcontroller.py (+6/-6)
Changed in openlp: | |
importance: | Undecided → Low |
Changed in openlp: | |
assignee: | nobody → Tomas Groth (tomasgroth) |
status: | New → In Progress |
Changed in openlp: | |
milestone: | none → 2.1.4 |
status: | In Progress → Fix Committed |
Changed in openlp: | |
status: | Fix Committed → Fix Released |