setup() takes at least 2 arguments (1 given)

[Eduard Biceri-Matei]

Trying to install devstack K on CI slave.

Local conf:
[[local|localrc]]
HOST_IP=10.140.0.3
FLAT_INTERFACE=eth0
FIXED_RANGE=10.150.0.0/16
FIXED_NETWORK_SIZE=255
FLOATING_RANGE=10.140.0.0/16
PUBLIC_NETWORK_GATEWAY=10.140.0.3
NETWORK_GATEWAY=10.150.0.1
MULTI_HOST=0
SYSLOG=False
SCREEN_LOGDIR=/opt/stack/logs/screen-logs
LOGFILE=/opt/stack/logs/stack.sh.log
ADMIN_PASSWORD=*
MYSQL_PASSWORD=*
RABBIT_PASSWORD=*
SERVICE_PASSWORD=*
SERVICE_TOKEN=*
CINDER_REPO=https://review.openstack.org/openstack/cinder
CINDER_BRANCH=refs/changes/01/152401/21

Error during install:
15-02-23 06:30:11.138 | ++ ls /opt/stack/status/stack/n-novnc.failure
2015-02-23 06:30:11.141 | + failures=/opt/stack/status/stack/n-novnc.failure
2015-02-23 06:30:11.141 | + for service in '$failures'
2015-02-23 06:30:11.142 | ++ basename /opt/stack/status/stack/n-novnc.failure
2015-02-23 06:30:11.143 | + service=n-novnc.failure
2015-02-23 06:30:11.143 | + service=n-novnc
2015-02-23 06:30:11.143 | + echo 'Error: Service n-novnc is not running'
2015-02-23 06:30:11.143 | Error: Service n-novnc is not running
2015-02-23 06:30:11.143 | + '[' -n /opt/stack/status/stack/n-novnc.failure ']'
2015-02-23 06:30:11.143 | + die 1494 'More details about the above errors can be found with screen, with ./rejoin-stack.sh'
2015-02-23 06:30:11.143 | + local exitcode=0
2015-02-23 06:30:11.143 | [Call Trace]
2015-02-23 06:30:11.143 | /opt/devstack/stack.sh:1297:service_check
2015-02-23 06:30:11.143 | /opt/devstack/functions-common:1494:die
2015-02-23 06:30:11.147 | [ERROR] /opt/devstack/functions-common:1494 More details about the above errors can be found with screen, with ./rejoin-stack.sh
2015-02-23 06:30:12.151 | Error on exit

Novnc screen:
stack@d-p-c-local-01-995:/opt/devstack$ /usr/local/bin/nova-novncproxy --config-
file /etc/nova/nova.conf --web /opt/stack/noVNC & echo $! >/opt/stack/status/sta
ck/n-novnc.pid; fg || echo "n-novnc failed to start" | tee "/opt/stack/status/st
ack/n-novnc.failure"
[1] 10200
/usr/local/bin/nova-novncproxy --config-file /etc/nova/nova.conf --web /opt/stack/noVNC
Traceback (most recent call last):
  File "/usr/local/bin/nova-novncproxy", line 9, in <module>
    load_entry_point('nova==2015.1.dev387', 'console_scripts', 'nova-novncproxy')()
  File "/opt/stack/nova/nova/cmd/novncproxy.py", line 45, in main
    port=CONF.novncproxy_port)
  File "/opt/stack/nova/nova/cmd/baseproxy.py", line 57, in proxy
    logging.setup("nova")
TypeError: setup() takes at least 2 arguments (1 given)
n-novnc failed to start
stack@d-p-c-local-01-995:/opt/devstack$

[Edward Hope-Morley (hopem)]

Looks like this is caused by the switch to oslo.log in commit 97d63d87.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/158236

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/158236
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=4fe64143cb4ceafbfa8580a34cfa75d599d48151
Submitter: Jenkins
Branch: master

commit 4fe64143cb4ceafbfa8580a34cfa75d599d48151
Author: Edward Hope-Morley <email address hidden>
Date: Mon Feb 23 10:37:12 2015 +0000

    Fixes novncproxy logging.setup()

    Switch to oslo.log broke things because
    oslo.log.setup() requires CONF but we
    were not supplying it to call.

    Change-Id: Idc752b13ba3a5ab24fb65eeea002af529f19278b
    Closes-Bug: 1424532

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/158388

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/158388
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=e799dabb56aff65c9fe4b5277f0656c630d9f0e0
Submitter: Jenkins
Branch: master

commit e799dabb56aff65c9fe4b5277f0656c630d9f0e0
Author: Matt Riedemann <email address hidden>
Date: Mon Feb 23 10:13:55 2015 -0800

    console: add unit tests for baseproxy

    Commit 97d63d8745cd9b3b391ce96b94b4da263b3a053d introduced a TypeError
    in baseproxy.

    That's fixed in commit 4fe64143cb4ceafbfa8580a34cfa75d599d48151 but
    while reviewing that change it was noticed that there is no unit test
    coverage for the baseproxy module, so it's added here.

    Related-Bug: #1424532

    Change-Id: If53409df2a8e3679a86454228cba27a50c005abe