Error in AccessControl/Owned.py/changeOwnership

Bug #142451 reported by Bug Importer
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Zope 2
Fix Released
Medium
Unassigned

Bug Description

Imagine you have a folder A and a subfolder A/B.

A's owner is user1, B's owner is user1 as well.

user2 should become owner of A but not of A/B.

But unchecking the "Also take ownership of all sub-objects" option doesn't work, user2 becomes owner of A/B as well.

Reason:

There's a little bug in AccessControl/Owned.py/changeOwnership:

The else part in the for loop changes ownership of children although "recursive" isn't set.
You just don't need the else part, and it works as desired.

Changed in zope2:
status: New → Confirmed
Changed in zope2:
assignee: nobody → Jens Vagelpohl (jens-dataflake)
Revision history for this message
Jens Vagelpohl (dataflake-deactivatedaccount-deactivatedaccount) wrote :

This is now fixed by removing the "else" branch in the code:

Zope 2.12 branch: http://svn.zope.org/?rev=112514&view=rev

Zope trunk: http://svn.zope.org/?view=rev&rev=112513

The checkin that introduced the faulty behavior even carries a message saying the author did not really understand what he was doing at that point.

Changed in zope2:
status: Confirmed → Fix Committed
Changed in zope2:
milestone: none → 2.12.7
Changed in zope2:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.