OpenStack Identity (keystone)

Use choices from oslo_config

Bug #1423973 reported by Lance Bragstad
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Wishlist
Eric Brown
Glance 11.0.0 "liberty"
OpenStack Compute (nova)
Fix Released
Wishlist
Eric Brown
OpenStack Compute (nova) 12.0.0 "liberty"
OpenStack Identity (keystone)
Fix Released
Wishlist
Lance Bragstad
OpenStack Identity (keystone) 8.0.0 "liberty"
keystonemiddleware
Fix Released
Wishlist
Eric Brown

Bug Description

Support went into oslo_config recently that will allow us to use the choices keyword argument from argparse [1]. We should look at leveraging this in Keystone.

[1] https://github.com/openstack/oslo.config/blame/578f9f4e60f58c210a9e1cb455925b9f310fe10e/oslo_config/cfg.py#L932

Lance Bragstad (lbragstad)
Changed in keystone:
importance: Undecided → Wishlist
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/157890

Changed in keystone:
assignee: nobody → Lance Bragstad (lbragstad)
status: New → In Progress
Eric Brown (ericwb)
Changed in python-keystoneclient:
importance: Undecided → Wishlist
assignee: nobody → Eric Brown (ericwb)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-keystoneclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/160018

Changed in python-keystoneclient:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-keystoneclient (master)

Change abandoned by Eric Brown (<email address hidden>) on branch: master
Review: https://review.openstack.org/160018
Reason: Change should be in keystonemiddleware

Eric Brown (ericwb)
no longer affects: python-keystoneclient
Changed in keystonemiddleware:
assignee: nobody → Eric Brown (ericwb)
importance: Undecided → Wishlist
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystonemiddleware (master)

Fix proposed to branch: master
Review: https://review.openstack.org/160031

Changed in keystonemiddleware:
status: New → In Progress
Eric Brown (ericwb)
Changed in nova:
importance: Undecided → Wishlist
assignee: nobody → Eric Brown (ericwb)
status: New → In Progress
Changed in glance:
assignee: nobody → Eric Brown (ericwb)
OpenStack Infra (hudson-openstack)
Changed in nova:
assignee: Eric Brown (ericwb) → Davanum Srinivas (DIMS) (dims-v)
Davanum Srinivas (DIMS) (dims-v)
Changed in nova:
assignee: Davanum Srinivas (DIMS) (dims-v) → Eric Brown (ericwb)
OpenStack Infra (hudson-openstack)
Changed in nova:
assignee: Eric Brown (ericwb) → Joe Gordon (jogo)
OpenStack Infra (hudson-openstack)
Changed in nova:
assignee: Joe Gordon (jogo) → Davanum Srinivas (DIMS) (dims-v)
OpenStack Infra (hudson-openstack)
Changed in nova:
assignee: Davanum Srinivas (DIMS) (dims-v) → Eric Brown (ericwb)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/157890
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=23bf8c9cb764721032087def54c89190eed204b8
Submitter: Jenkins
Branch: master

commit 23bf8c9cb764721032087def54c89190eed204b8
Author: Lance Bragstad <email address hidden>
Date: Fri Feb 20 17:53:02 2015 +0000

    Use choices in config.py

    The oslo_config library supports the choices keyword argument. This commit
    leverages the use of choices for StrOpts in Keystone's configuration.

    Change-Id: Ib276e22e56eff09ac5a43fb7b93170776806fd12
    Closes-Bug: 1423973

Changed in keystone:
status: In Progress → Fix Committed
Kamil Rykowski (kamil-rykowski)
Changed in glance:
importance: Undecided → Wishlist
Revision history for this message
Kamil Rykowski (kamil-rykowski) wrote :

Support in Glance has been provided in https://review.openstack.org/#/c/158576/

Changed in glance:
status: New → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/158573
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=ed9f1b8b43161c1bc637022aaf67fb5f7a21b0f6
Submitter: Jenkins
Branch: master

commit ed9f1b8b43161c1bc637022aaf67fb5f7a21b0f6
Author: Eric Brown <email address hidden>
Date: Mon Feb 23 22:04:55 2015 -0800

    Use oslo_config choices support

    The oslo_config library supports the choices keyword argument. This commit
    leverages the use of choices for StrOpts in Nova's configuration.

    This change also adds 'ploop' as a valid value for the images_type option.
    This was previously a valid value, but not documented.

    Closes-Bug: #1423973

    Change-Id: I4c0eb1366cc8a1b001fd403b67c3eec11f831541

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in glance:
milestone: none → liberty-1
status: Fix Committed → Fix Released
Doug Hellmann (doug-hellmann)
Changed in keystone:
milestone: none → liberty-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: none → liberty-1
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on keystonemiddleware (master)

Change abandoned by Eric Brown (<email address hidden>) on branch: master
Review: https://review.openstack.org/160031

Thierry Carrez (ttx)
Changed in nova:
milestone: liberty-1 → 12.0.0
Thierry Carrez (ttx)
Changed in keystone:
milestone: liberty-1 → 8.0.0
Thierry Carrez (ttx)
Changed in glance:
milestone: liberty-1 → 11.0.0
Revision history for this message
Steve Martinelli (stevemar) wrote :

removing assignee due to inactivity

Changed in keystonemiddleware:
status: In Progress → Triaged
assignee: Eric Brown (ericwb) → nobody
OpenStack Infra (hudson-openstack)
Changed in keystonemiddleware:
assignee: nobody → Eric Brown (ericwb)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystonemiddleware (master)

Reviewed: https://review.openstack.org/160031
Committed: https://git.openstack.org/cgit/openstack/keystonemiddleware/commit/?id=39560c774874c7df0bff70a40992a722754a9d24
Submitter: Jenkins
Branch: master

commit 39560c774874c7df0bff70a40992a722754a9d24
Author: Eric Brown <email address hidden>
Date: Fri Feb 27 14:27:49 2015 -0800

    Use oslo_config choices support

    The oslo_config library added support for a choices keyword argument in
    version 1.2.0a3. This commit leverages the use of choices for StrOpts of
    keystonemiddleware configuration.

    Change-Id: I8d9ee833263560caaffe083487abc5eda862f8ea
    Closes-Bug: 1423973

Changed in keystonemiddleware:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/keystonemiddleware 4.1.0

This issue was fixed in the openstack/keystonemiddleware 4.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.