repeated make iso results in *.rpm.1 files

[Matthew Mosesohn]

ISO build fails if you make iso, run into a fault, then re-run make iso:
genisoimage: Error: /home/mmosesohn/fuel-main/build/iso/isoroot-mkisofs/Packages/openstack-swift-plugin-swift3-1.0.0-0.20120711git.el6.noarch.rpm and /home/mmosesohn/fuel-main/build/iso/isoroot-mkisofs/Packages/openstack-swift-plugin-swift3-1.0.0-0.20120711git.el6.noarch.rpm.1 have the same Joliet name
Joliet tree sort failed. The -joliet-long switch may help you.

This horses you to make clean and try again. Instead, we should run wget with --unlink option to prevent writing ".1" files.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/157730

[Alexei Sheplyakov (asheplyakov)]

> This horses you to make clean and try again.

Actually this is not the only reason why building ISO requires a clean initial state. Say, if building an IBP image fails,
it might leave around several mounted loopback devices (hoilding a chroot full of unconfigured packages), etc.
Therefore the rule of the thumb is "if something failed, run make deep_clean".

[Nick Sun (sunxin3)]

I also hit this issue. :(

openstack-neutron-linuxbridge-2014.2.2-fuel6.1.mira17.noarch.rpm.1
openstack-neutron-oneconvergence-nvsd-2014.2.2-fuel6.1.mira17.noarch.rpm
openstack-neutron-openvswitch-2014.2.2-fuel6.1.mira17.noarch.rpm.1

The length of 3 above packages'name are more than 64 characters, while the Joliet iso format only support the file which name is less than 64 character, I think we may add the switch : -joliet-long to the command: mkisofs for support so long rpm's file name.

Thanks!
Nick

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/157730
Committed: https://git.openstack.org/cgit/stackforge/fuel-main/commit/?id=ee112acfdd0f9017ef40be53e8e51bb5c429e97c
Submitter: Jenkins
Branch: master

commit ee112acfdd0f9017ef40be53e8e51bb5c429e97c
Author: Matthew Mosesohn <email address hidden>
Date: Fri Feb 20 14:52:33 2015 +0300

    Prevent filename.rpm.1 downloads

    wget defaults to appending ".1" to filenames when
    downloading files that already exists. Switching
    to timestamp mode (-N) forces wget to replace
    existing file only when there is a newer file
    on the server. This applies just to downloading
    RPM files currently.

    Change-Id: Ifc63abb181d53255105e620b26fd9e81611cdc5e
    Closes-Bug: #1423874