Instance overview renders erroneous markup

Bug #1423797 reported by Kit Randel
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Alex Chan

Bug Description

Under Instance Detail | Overview | Meta | Key Name an unclosed </em> is rendered.

See attached image.

Tags: markup trivial
Revision history for this message
Kit Randel (blr) wrote :
Yash Bathia (ybathia)
Changed in horizon:
assignee: nobody → Yash Bathia (ybathia)
Revision history for this message
Rob Cresswell (robcresswell-deactivatedaccount) wrote :

I can't recreate this. Need someone else to confirm, or check it is still a bug.

Changed in horizon:
status: New → Incomplete
Revision history for this message
Alex Chan (alexc2-3) wrote :

I've seen this happen. Is it ok if I take a stab at this?

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/164284

Changed in horizon:
assignee: Yash Bathia (ybathia) → Alex Chan (alexc2-3)
status: Incomplete → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/164284
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=cf152365cd68ffa7572efa2777faf7057dccb044
Submitter: Jenkins
Branch: master

commit cf152365cd68ffa7572efa2777faf7057dccb044
Author: Alex Chan <email address hidden>
Date: Fri Mar 13 10:47:30 2015 -0700

    Instance overview renders erroneous markup

    Under Instance Detail | Overview | Meta | Key Name an unclosed </em>
    is rendered for an instance launched without an associated key pair.
    This seems to be reproducible using Django 1.6.1 in local devstack.
    The issue seems to be that Django's implementation of the add filter
    has an issue concatenating a string and a function to localize text.
    Since that fails and returns an empty string which subsequently is
    added to the closing </em> tag, the closing tag is the only thing
    that is displayed.

    This fix saves the localized value to a variable which is then used
    in the add filter.

    Closes-Bug: #1423797
    Change-Id: I4452ca4a902bbaf19ae5b2bd9bcbe2900069ac3b

Changed in horizon:
status: In Progress → Fix Committed
Changed in horizon:
importance: Undecided → Low
milestone: none → liberty-1
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: liberty-1 → 8.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.