After reload, all percentages are blue until they are updated again

Bug #1423468 reported by SirVer
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Fix Released
Undecided
TiborB

Bug Description

When realoading a game, all percentage displays are blue, instead of the correct color (red, green, yellow) until they are updated once.

Seen on r7412.

Related branches

SirVer (sirver)
Changed in widelands:
status: New → Incomplete
Revision history for this message
TiborB (tiborb95) wrote :

yes, blue percentages was introduced in one of my AI branches, but this was bit undiscussed. The basic question is whether we get rid of that blue color altogether, or try to fix the behaviour after game loading.

Revision history for this message
SirVer (sirver) wrote :

What does that blue mean? I remember dimly talking about it... Did you introduce that feature?

Revision history for this message
wl-zocker (wl-zocker) wrote :

> What does that blue mean?

If even you don't know, there is clearly a lack of documentation.

I assumed that blue stands for buildings that skip their work, but that seems not to be true.
Also, a simple update seems not to be enough: I saw a lumberjack return to his hut and the number stayed blue.

Revision history for this message
TiborB (tiborb95) wrote :

well there are now two statistics (% of performance) - official one, shown above the building, and mine used for AI - more reflecting actual perfomance but less accurate (yes seems like contradiction)

if (official_statistics > my_statistics+ 60%) then color=blue

(I am not sure with % now)

my statistics starts with 0% and it takes few production cycles till blue color dissapears, providing that official statistics is still 100 or so....

change of color can be avoided, or my statistics can start from 50% (bearable for AI)

Revision history for this message
wl-zocker (wl-zocker) wrote :

That sound like a debugging tool for AI programming. Since players do not know the algorithm of the AI, they can do nothing with this information. I suggest to remove it then.

I do not know why I thought of of buildings skipping their work, but is there an interest in marking the percentage in yet another color? I think there is a difference between a 30% building with missing input wares and a 30% building that has all input, but its output is not needed.

Revision history for this message
TiborB (tiborb95) wrote :

From different angle - a question "do I need another building of this kind if utilization of current buildings is 100%". Here 100% does not provide the answer. AI needs to know actual utilization when making decisions whether to built another building of a kind....

I undestand that a user has no idea what that could mean. I can remove the blue color - no problem.

TiborB (tiborb95)
Changed in widelands:
assignee: nobody → TiborB (tiborb95)
status: Incomplete → In Progress
Revision history for this message
SirVer (sirver) wrote :

#5: I remember that there was a suggestion and talk about implementing exactly that - blue means skipped. But I think it never got implemented. Then I started to see the blue colors pop up and I thought that I remembered wrongly and it was indeed implemented....

I agree that this has no value for the player. +1 for removing the blue color again.

Revision history for this message
TiborB (tiborb95) wrote :

I am already testing the fix....

I probably repeat what I said, but the actual statistics does not refer to "capacity utilization" as somebody might expect but to something bit cryptic...

Revision history for this message
TiborB (tiborb95) wrote :

changed (blue color removed) in rev 7415

Changed in widelands:
status: In Progress → Fix Committed
Changed in widelands:
milestone: none → build19-rc1
GunChleoc (gunchleoc)
Changed in widelands:
status: Fix Committed → Fix Released
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build19-rc1.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.