Heat scaling group doesn't override the update_policy_schema

Bug #1423426 reported by Angus Salkeld
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Low
Angus Salkeld
Kilo
Fix Released
Low
Angus Salkeld

Bug Description

As I have been reworking tests I have noticed that:

instance group has the update policy as
  "Resources" : {
    "JobServerGroup" : {
      "UpdatePolicy" : {
        "RollingUpdate" : {

aws scale group
    'Resources': {
    'WebServerGroup': {
      "UpdatePolicy": {

and os::Heat::scalegroup
        resources:
          my-group:
            properties:
              rolling_updates:

This is all fine and well'ish, but because the heat scalegroup inherits from the aws one it kinda allows the UpdatePolicy.
(it then gets confused with PauseTime/pause_time and doesn't actually use the UpdatePolicy in the code)

I think we just need:
    update_policy_schema = {}

Angus Salkeld (asalkeld)
Changed in heat:
importance: Undecided → Low
status: New → Triaged
assignee: nobody → Angus Salkeld (asalkeld)
milestone: none → kilo-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/158549

Changed in heat:
status: Triaged → In Progress
Angus Salkeld (asalkeld)
summary: - Heat scaling group doesn't overridet the update_policy_schema
+ Heat scaling group doesn't override the update_policy_schema
Changed in heat:
milestone: kilo-3 → kilo-rc1
Angus Salkeld (asalkeld)
Changed in heat:
milestone: kilo-rc1 → liberty-1
Steven Hardy (shardy)
tags: added: kilo-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/158549
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=d84c9bc0a6065a077ef7590aaec870ff3a34a20a
Submitter: Jenkins
Branch: master

commit d84c9bc0a6065a077ef7590aaec870ff3a34a20a
Author: Angus Salkeld <email address hidden>
Date: Tue Apr 7 15:26:25 2015 +1000

    Make sure UpdatePolicy is unset for Heat scaling group

    It is defined within the properties as rolling_updates.
    This patch is to make it more obvious to users that UpdatePolicy
    is not supported.

    Change-Id: I8162d27036843d0b9282cd8f4aa4d2eb93afba19
    Closes-bug: 1423426

Changed in heat:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in heat:
status: Fix Committed → Fix Released
Angus Salkeld (asalkeld)
tags: removed: kilo-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/224959

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (stable/kilo)

Reviewed: https://review.openstack.org/224959
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=5d084a26329b9f8f1db074ba1dba86be0d7fd575
Submitter: Jenkins
Branch: stable/kilo

commit 5d084a26329b9f8f1db074ba1dba86be0d7fd575
Author: Angus Salkeld <email address hidden>
Date: Tue Apr 7 15:26:25 2015 +1000

    Make sure UpdatePolicy is unset for Heat scaling group

    It is defined within the properties as rolling_updates.
    This patch is to make it more obvious to users that UpdatePolicy
    is not supported.

    Change-Id: I8162d27036843d0b9282cd8f4aa4d2eb93afba19
    Closes-bug: 1423426
    (cherry picked from commit d84c9bc0a6065a077ef7590aaec870ff3a34a20a)

Thierry Carrez (ttx)
Changed in heat:
milestone: liberty-1 → 5.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.