Internal error in case of MalformedRequestBody

[Andrew Lazarev]

Steps to reproduce:
1. Send malformed request to Sahara

Observed behavior: 500 error with { "error_message": "format requires a mapping"} message

Stacktrace:

2015-02-18 14:22:44.640 8687 TRACE sahara.api File "/Users/alazarev/openstack/sahara/sahara/utils/wsgi.py", line 243, in _from_json
2015-02-18 14:22:44.640 8687 TRACE sahara.api raise exceptions.MalformedRequestBody(msg)
2015-02-18 14:22:44.640 8687 TRACE sahara.api File "/Users/alazarev/openstack/sahara/sahara/exceptions.py", line 330, in __init__
2015-02-18 14:22:44.640 8687 TRACE sahara.api self.message = self.message % reason
2015-02-18 14:22:44.640 8687 TRACE sahara.api File "/Users/alazarev/openstack/sahara/.tox/venv/lib/python2.7/site-packages/oslo_i18n/_message.py", line 112, in __mod__
2015-02-18 14:22:44.640 8687 TRACE sahara.api unicode_mod = super(Message, self).__mod__(params)
2015-02-18 14:22:44.640 8687 TRACE sahara.api TypeError: format requires a mapping

Cause:

Issue was introduced in https://review.openstack.org/#/c/153526/
Here is code with bug:

class MalformedRequestBody(SaharaException):
    message = _("Malformed message body: %(reason)s")

    def __init__(self, reason):
        self.message = self.message % reason

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/157176

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/157176
Committed: https://git.openstack.org/cgit/openstack/sahara/commit/?id=f831a3f563cd18c6c14377d6706d9047c13f0d54
Submitter: Jenkins
Branch: master

commit f831a3f563cd18c6c14377d6706d9047c13f0d54
Author: Andrew Lazarev <email address hidden>
Date: Wed Feb 18 14:32:06 2015 -0800

    Fixed format mapping in MalformedRequestBody

    Change-Id: I3039b95b7564098fc36f8a46a4238a90e227f307
    Closes-Bug: #1423369