VPN - Peer ID gets additional "@" every reload of vpn service

[Tobias]

Hi all,

1. Add IPSec site to site connection with peer: "tobi.dyndns.org" and peer-id: "@tobi.dyndns.org".
2. Establish IPSec connection
3. Add/Update/Delete other IPSec connection
4. As result of 3. the vpn process on network node gets restarted.
5. After restart an additional "@" is added at the beginning of the peer-id. New peer id is "@@tobi.dyndns.org"
6. An update of peer-id in horizon results in an additional "@", too.

I verified the peer id in the neutron database. Peer id is updated in the neutron database too.

[Numan Siddique (numansiddique)]

I am able to reproduce the issue.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/158074

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/158516
Committed: https://git.openstack.org/cgit/openstack/neutron-vpnaas/commit/?id=62dffba3d75376a91f2b971f571cd749c04a78a5
Submitter: Jenkins
Branch: master

commit 62dffba3d75376a91f2b971f571cd749c04a78a5
Author: Sridhar Ramaswamy <email address hidden>
Date: Mon Feb 23 15:20:32 2015 -0800

    VPNaaS refactor service driver to reuse VpnDriver code

    Introduce BaseIPsecVpnDriver class to host most of the
    common code to be shared across various implementations
    of VPN service-drivers. This reduces the duplicate code
    in these service-drivers

    Closes-Bug: #1422905
    Related-Bug: #1423244
    Co-Authored-By: Numan Siddique <email address hidden>
    Change-Id: Ibde249af5c7228e2f9b7496cb03bd9b516966ef5

[Numan Siddique (numansiddique)]

https://git.openstack.org/cgit/openstack/neutron-vpnaas/commit/?id=62dffba3d75376a91f2b971f571cd749c04a78a5 fixes this bug.

Review https://review.openstack.org/158074 only adds the test cases for the fix.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/158074
Committed: https://git.openstack.org/cgit/openstack/neutron-vpnaas/commit/?id=9f886afc28d7896119fae6bd618054a500f2fa93
Submitter: Jenkins
Branch: master

commit 9f886afc28d7896119fae6bd618054a500f2fa93
Author: Numan Siddique <email address hidden>
Date: Thu Feb 26 19:40:24 2015 +0530

    Add test case for the 'Peer ID gets additional "@"' fix

    Review https://review.openstack.org/#/c/158516/)
    fixes the bug #1423244.

    This patch adds the test case for this bug fix.

    Change-Id: Iaed2ef7dbff5f99b355e738a99cbd127924a9675
    Related-bug: #1423244