Secret key generation test should use less permissive chmod

Bug #1422891 reported by Gabriel Hurley
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Gabriel Hurley

Bug Description

While working on the Bandit framework with the OpenStack Security Group it flagged the chmod 777 in the SecretKeyTests.test_generate_or_read_key_from_file test.

While this is a trivial issue that applies only to the test suite, using a 644 permission accomplishes the same thing and is better principle. Also it makes Bandit happy, and it's one less thing to flag in the future.

Changed in horizon:
status: New → Confirmed
importance: Undecided → Low
assignee: nobody → Gabriel Hurley (gabriel-hurley)
milestone: none → kilo-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/156752

Changed in horizon:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/156752
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=1149cd85665cf6a5841a462859779336037a44b8
Submitter: Jenkins
Branch: master

commit 1149cd85665cf6a5841a462859779336037a44b8
Author: Gabriel Hurley <email address hidden>
Date: Tue Feb 10 22:40:15 2015 -0800

    Use less permissive chmod in secret key test

    Switch to using 644 instead of 777 for a trivial increase
    in "best practice security".

    Closes Bug: #1422891

    Change-Id: I74dad5ae017b234f23d6e4a1b9099c62a1cd1e09

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: kilo-3 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.