Operating System: Ubuntu 14.04.1 LTS
Mahara version: 1.9.3
Database: mysql
Browser: chrome 40.0.2214.111
------------------------------
Steps to reproduce - you need a system capable of XMLRPC communication with Mahara (e.g. Moodle)
1) With Moodle - set up mahara networking / portfolios.
2) Open a course with a forum
3) Add 2 entries. One with an attachment under 5 MB. One with an attachment over 5 MB. On Each click "Export to portfolio" in the bottom. 4) Go through the screens to start export - ask it to do it now (i.e. not wait for cron).
5) Check the Mahara site to see what made it through successfully.
------------------------------
simpleXML may not be the best parser for XMLRPC payloads
in api/xmlrpc/lib.php
function parse_payload($payload) {
try {
$xml = new SimpleXMLElement($payload);
return $xml;
} catch (Exception $e) {
throw new MaharaException('Encrypted payload is not a valid XML document', 6002);
}
}
This means if you send a large file (in our tests greater than approx 7mb) base 64 encoded over XMLRPC it will fail to parse.
It didn't seem to make any difference if we increased the memory limit to 800M in php.ini or even by setting the php memory limit to 800M via PHP ini_set in function parse_payload - this suggests that there is a limit to what SimpleXML can handle regardless of the PHP memory limit.
Note - 932 in my source code is the 'throw new exception' following $xml = new SimpleXMLElement($payload);
called at [/vagrant/www/maharadev/mahara/lib/errors.php:465] #1 exception(MaharaException Object ([] => 1,[] => Encrypted payload is not a valid XML document,[] => ,[] => 6002,[] => /vagrant/www/maharadev/mahara/api/xmlrpc/lib.php,[] => 932,[] => Array ([0] => Array ([file] => /vagrant/www/maharadev/mahara/api/xmlrpc/lib.php,[line] => 921,[function] => parse_payload,[args] => Array ([0] =>ERROR 4:
4: remote server error: code: , message: A nonrecoverable error occurred. This probably means you have encountered a bug in the system #0 MaharaException->handle_exception() called at [/vagrant/www/maharadev/mahara/lib/errors.php:465] #1 exception(MaharaException Object ([] => 1,[] => Encrypted payload is not a valid XML document,[] => ,[] => 6002,[] => /vagrant/www/maharadev/mahara/api/xmlrpc/lib.php,[] => 932,[] => Array ([0] => Array ([file] => /vagrant/www/maharadev/mahara/api/xmlrpc/lib.php,[line] => 921,[function] => parse_payload,[args] => Array ([0] =>
Hi Guy,
Thanks for the bug report! What version of Moodle are you using? And were there any other additional configuration steps you had to take, to be able to export a Moodle forum post with a file attachment?
I ask because I wasn't able to get any file attachment to go through from Moodle to Mahara. I tried Moodle 2.6 and 2.8, and I found that when I attached a file to a Moodle forum post, Moodle did not display the "Export to portfolio" link next to that particular post.
I also tried using the TinyMCE "image" embed button, to put a very small image into a Moodle forum post. This did show me the "Export to portfolio" link, but it gave the error "No common formats between any available portfolio plugin and the calling location forum_portfolio
It's worth noting that we're in the process of replacing MNet with a new webservices system. But, the new webservices system also uses SimpleXML, so it may well face this same problem.
Cheers,
Aaron