Mahara doesn't ask you for your password before changing your username

[Aaron Barnes]

These, especially the first, seem like dangerous operations.

Expected behavior is that Mahara would prompt for my current password to prevent someone deleting my user account if I left my account logged in.

[Aaron Wells (u-aaronw)]

Indeed, if we wanted to be more secure, we could consider asking for password, and/or sending out email notifications, when certain user actions take place. I think maybe a good rule of thumb, is any action that can prevent you from being able to log in. So that would be:

1. Changing your password (we already ask for your current password for this)
2. Changing your username
3. Changing your primary email address (because this can make it impossible to recover your password)
4. Deleting your own account

[Robert Lyon (robertl-9)]

A problem here is if the user logged in via SSO they don't have/know a password in Mahara

[Robert Lyon (robertl-9)]

Because of the fact a user can SSO in and so they do not have a valid password in Mahara itself we can't force them to re-enter their password to do the following:

1. Changing your username
2. Changing your primary email address (because this can make it impossible to recover your password)
3. Deleting your own account

However we now have some more security around

2. Changing your primary email - we now have a check where when a new email address is being added to the account the existing email addresses get sent a 'heads up' message about the new email address.
3. Deleting your own account - we now have the ability to set a site setting where users deleting their accounts go to a pending confirmation queue which admins need to verify

As for

1. Changing your username

we could send email to user's accounts as a 'heads up' for this as well

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/8589

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/8589
Committed: https://git.mahara.org/mahara/mahara/commit/8ad4343d97be9d248088bc64ceaa510d213e1151
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 8ad4343d97be9d248088bc64ceaa510d213e1151
Author: Robert Lyon <email address hidden>
Date: Thu Mar 8 10:02:57 2018 +1300

Bug 1422492: Make user enter current password if changing their username

As the change username option only appears on account index page for
those users that have an auth method allowing it we should make the
user also supply their current password when changign username

We hide the confirm password box for username change until they try to
change it

behatnotneeded

Change-Id: Ic05d3c258d331305ae5c07b952ea2a561a8badf1
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Patch for "18.04_STABLE" branch: https://reviews.mahara.org/8704

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/8704
Committed: https://git.mahara.org/mahara/mahara/commit/cc3a72945b4f68a3b9ffedca26c877619e348b1f
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.04_STABLE

commit cc3a72945b4f68a3b9ffedca26c877619e348b1f
Author: Robert Lyon <email address hidden>
Date: Thu Mar 8 10:02:57 2018 +1300

Bug 1422492: Make user enter current password if changing their username

As the change username option only appears on account index page for
those users that have an auth method allowing it we should make the
user also supply their current password when changign username

We hide the confirm password box for username change until they try to
change it

behatnotneeded

Change-Id: Ic05d3c258d331305ae5c07b952ea2a561a8badf1
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 8ad4343d97be9d248088bc64ceaa510d213e1151)

[Kristina Hoeppner (kris-hoeppner)]

We'd still need to deal with asking for the password when self-deleting an account. I created bug #1758801 for that.