Nova-network do not honour parameter vlan_interface when configured with VlanManager and used with vCenter as hypervisor

[Igor Zinovik]

When Fuel deploys OpenStack that will be using vCenter and nova-network with VlanManager
special option [vmware]/vlan_interface must be configured in /etc/nova/nova.conf configuration file.

Right now nova-network is started as pacemkaker resource and uses only /etc/nova/nova.conf file,
but actually [vmware]/vlan_interface option is written to nova-compute configuration files in
/etc/nova/nova-compute.d/

Expected resut:
Nova-network provisions VLANs using vCenter on specified vmnic network interface.

Actual result:
Nova-network always uses default value vmnic0 with regard what user specified in "ESXi host
interface" option on the Settings tab.

Workaround:
$ echo "[vmware]" >> /etc/nova/nova.conf
$ echo "vlan_interface=vmnic1" >> /etc/nova/nova.conf
$ pcs resource disable p_vcenter_nova_network
$ pcs resource enable p_vcenter_nova_network

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/155977

[Igor Zinovik (izinovik)]

Option [vmware]vlan_interface is consumed by nova-compute service, not nova-network.

Current behaviour is correct.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Igor Zinovik (<email address hidden>) on branch: master
Review: https://review.openstack.org/155977
Reason: Not a bug.

Current code works correctly.