Plug-in architect should allow for spec files to be added
Bug #1421778 reported by
Shaoquan Chen
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Dashboard (Horizon) |
Fix Released
|
Wishlist
|
Shaoquan Chen |
Bug Description
Currently the plug-in architecture only allows for JavaScript source code files added form apps/panels, we need to extend the architecture to allow for spec(unit test) files to be added to Jasmine spec runner as well.
Besides, the JS files order is not respected by the current architecture, but the order is significant, this need to be fixed too.
summary: |
- Need a directory-base approach to collecting JS source and spec files + Plug-in architect need to allow spec files to be added |
description: | updated |
Changed in horizon: | |
assignee: | nobody → Shaoquan Chen (sean-chen2) |
status: | New → Fix Committed |
status: | Fix Committed → New |
summary: |
- Plug-in architect need to allow spec files to be added + Plug-in architect should allow for spec files to be added |
Changed in horizon: | |
status: | New → In Progress |
Changed in horizon: | |
milestone: | none → kilo-3 |
importance: | Undecided → Wishlist |
Changed in horizon: | |
status: | In Progress → Fix Committed |
Changed in horizon: | |
status: | Fix Committed → Fix Released |
Changed in horizon: | |
milestone: | kilo-3 → 2015.1.0 |
To post a comment you must log in.
Reviewed: https:/ /review. openstack. org/153927 /git.openstack. org/cgit/ openstack/ horizon/ commit/ ?id=49af820365f 4f7bae947d6388a 09f86b3d7c5e41
Committed: https:/
Submitter: Jenkins
Branch: master
commit 49af820365f4f7b ae947d6388a09f8 6b3d7c5e41
Author: Shaoquan Chen <email address hidden>
Date: Sun Feb 8 22:00:18 2015 -0800
Extending Horizon's plug-in architecture to Jasmine
Horizon has a well-defined plug-in architecture, but the
architecture doesn't cover Horizon's Jasmine spec runner.
This patch fills the gap.
This patch also dashboard/ utils/settings. py where using python set topics/ settings. rst to include the newly added field.
- defines a new field `js_spec_file` in HORIZON_CONFIG in settings.
- fix a bug openstack_
to collect js files, which will cause the order of the js file lost.
Change is made to use list to respect the js files order.
- update doc/source/
Change-Id: Idc122e8b1f917c dd344aa8f4b48fd 80a6bdddb70
Close-Bug: 1421778