Incorrect usage of drop_constraint in 2a1ee2fb59e0 migration

Bug #1421631 reported by Ann Taraday
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Undecided
Ann Taraday

Bug Description

Downgrade for migration 2a1ee2fb59e0_add_mac_address_unique_constraint fails as it gets wrong parameters name, source and local_cols, although it expects name, source and type_ http://alembic.readthedocs.org/en/latest/ops.html#alembic.operations.Operations.drop_constraint

Error - http://paste.openstack.org/show/172906/

Also as MySQL create index for unique constraint it should be used "with migration.remove_fks_from_table", as it gets an error - http://paste.openstack.org/show/172907/

Changed in neutron:
assignee: nobody → Ann Kamyshnikova (akamyshnikova)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/155737

Changed in neutron:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/155737
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=77c073b743a257781b068552ca2af175c4c2cd30
Submitter: Jenkins
Branch: master

commit 77c073b743a257781b068552ca2af175c4c2cd30
Author: Ann Kamyshnikova <email address hidden>
Date: Fri Feb 13 15:52:49 2015 +0300

    Fix usage drop_constraint in 2a1ee2fb59e0 migration

    Downgrade for migration 2a1ee2fb59e0_add_mac_address_unique_constraint
    fails as it gets wrong parameters name, source and local_cols,
    although it expects name, source and type_.

    Also as MySQL creates index for unique constraint it should be used
    "with migration.remove_fks_from_table".

    Closes-bug: #1421631

    Change-Id: Id86b2f339a6fb33fc4fd637ffbfc2cb6e75ef4fb

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
milestone: none → kilo-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: kilo-3 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.