python-fuelclient run_test.sh misses option to run pep8/flake8/hacking checks

Bug #1421549 reported by Sebastian Kalinowski
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
Medium
Bartłomiej Piotrowski

Bug Description

When python-fuelclient was a part of fuel-web repository it was possible to run pep8/flake8/hacking checks like that:

# ./run_tests.sh -p

Right now run_tests.sh do not have this option - user need to use:

# tox -e pep8

Even if it's completely normal, it is not a quite obvious way to do it since run_test.sh is a main way to run tests for python-fuelclient, therefor '-p' flag to run "tox -e pep8" should be brought back and
should be executed as part of default (with no options) ./run_tests.sh run.

summary: - python-fuelcleint run_test.sh misses option to run pep8/flake8/hacking
+ python-fuelclient run_test.sh misses option to run pep8/flake8/hacking
checks
description: updated
Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Bartlomiej Piotrowski (bpiotrowski)
Changed in fuel:
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-fuelclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/164650

Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
Roman Prykhodchenko (romcheg) wrote :

run_test.sh is only required for running specific tests in FuelCI
PEP8 tests can be runned by invoking tox -epep8

Revision history for this message
Roman Prykhodchenko (romcheg) wrote :

I think this bug is more about the absense of a single entry point to launch all tests. In the review-request I made a suggestion how to achieve that in a way which is more complient with the upstream OpenStack so I'd like to invite folks to discuss that.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-fuelclient (master)

Reviewed: https://review.openstack.org/164650
Committed: https://git.openstack.org/cgit/stackforge/python-fuelclient/commit/?id=052d55fc9aa803eda5a3e4ac482174e6838f5541
Submitter: Jenkins
Branch: master

commit 052d55fc9aa803eda5a3e4ac482174e6838f5541
Author: Bartłomiej Piotrowski <email address hidden>
Date: Mon Mar 16 12:18:56 2015 +0100

    Add Flake8 tests to run_tests.sh

    Tests are run by default, but this can be via -o or --no-pep8 flags.
    Additionally, there is a flag to run only Flake8 tests (-p).

    I took the liberty to do a better aligment of switch statement.

    Change-Id: I39383fe56ebafb4d031d569b17855ae691ada7bf
    Closes-Bug: 1421549

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Change abandoned on fuel-infra/jenkins-jobs (master)

Change abandoned by Aleksandra Fedorova <email address hidden> on branch: master
Review: https://review.fuel-infra.org/4681
Reason: Outdated

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.