functional tests - remove datadriven tests from smoke tests

Bug #1420868 reported by Steve Heyman
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-barbicanclient
Fix Released
Medium
Thomas Dinkjian

Bug Description

We have data-driven tests in our smoke tests that really belong under functional.

Revision history for this message
Thomas Dinkjian (thomas-dinkjian) wrote :

I have confirmed that there was a Data driven test in our smoke test file.

    @utils.parameterized_dataset({
        'alphanumeric': ['1f34ds'],
        'punctuation': ['~!@#$%^&*()_+`-={}[]|:;<>,.?'],
        'uuid': ['54262d9d-4bc7-4821-8df0-dc2ca8e112bb'],
        'len_255': [str(bytearray().zfill(255))],
        'empty': [''],
        'null': [None]
    })
    @testcase.attr('positive')
    def test_secret_get_defaults_metadata_w_valid_name(self, name):
        """Covers getting and checking a secret's metadata."""
        test_model = self.behaviors.create_secret(secret_create_defaults_data)
        test_model.name = name

        secret_ref = self.behaviors.store_secret(test_model)
        self.assertIsNotNone(secret_ref)

        get_resp = self.behaviors.get_secret(secret_ref)
        self.assertEqual(get_resp.status, "ACTIVE")
        self.assertEqual(get_resp.name, name)
        self.assertEqual(get_resp.mode, test_model.mode)
        self.assertEqual(get_resp.algorithm, test_model.algorithm)
        self.assertEqual(get_resp.bit_length, test_model.bit_length)

I have moved this test to the functional test suite.

Changed in python-barbicanclient:
assignee: nobody → Thomas Dinkjian (thomas-dinkjian)
status: New → Confirmed
Changed in python-barbicanclient:
status: Confirmed → In Progress
Changed in python-barbicanclient:
milestone: none → 3.0.3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-barbicanclient (master)

Reviewed: https://review.openstack.org/160490
Committed: https://git.openstack.org/cgit/openstack/python-barbicanclient/commit/?id=5b71440b67b6f17b648f5cdd915684c986edef18
Submitter: Jenkins
Branch: master

commit 5b71440b67b6f17b648f5cdd915684c986edef18
Author: Thomas Dinkjian <email address hidden>
Date: Mon Mar 2 14:31:09 2015 -0600

    Moved parameterized test from smoke to functional

    There was a parameterized test in our smoke tests section. I have
    moved the test from smoke to functional.

    Closes-Bug: #1420868

    Change-Id: Idf704925b05a8e8b134a630b73ea849263c48831

Changed in python-barbicanclient:
status: In Progress → Fix Committed
Changed in python-barbicanclient:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-barbicanclient 3.0.3

This issue was fixed in the openstack/python-barbicanclient 3.0.3 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.