adt-run's --timeout-factor option doesn't do anything

[Robie Basak]

I'm hitting a copy timeout testing mysql-5.6. I used --timeout-factor=10, but this didn't seem to help. I'm now trying --timeout-copy=3000 explicitly.

I took a look at the code. Although --timeout-factor is defined, I can't see the value being used anywhere (I grepped for "factor"). So am I missing something, or has the code that implemented this disappeared? It seems to me that it is falsely documented to exist.

I'm using version 3.5.1, but I also checked the source in current git master (tagged 3.9.5).

[Martin Pitt (pitti)]

Indeed it seems I simply forgot to implement this with the adt_run_args.py refactoring.

[Martin Pitt (pitti)]

http://anonscm.debian.org/cgit/autopkgtest/autopkgtest.git/commit/?id=f9219a7fc7dec

[Launchpad Janitor (janitor)]

This bug was fixed in the package autopkgtest - 3.9.6

---------------
autopkgtest (3.9.6) unstable; urgency=medium

  * Skip test_tmp_install_imagemagick test case if python3-wand is not
    available.
  * adt-virt-ssh: Ignore errors when cleaning up the work dir. This races with
    sshd cleaning up its control socket, don't stumble over that.
    (LP: #1420355)
  * Implement --timeout-factor, which was forgotten with the rewrite in
    version 3.2. (LP: #1420540)
  * ssh-setup/adb: Fix waiting for the desktop to boot: Lower D-Bus call
    timeout to 5 seconds, and fix retry loop to time out afer 5 minutes of
    real time instead of a fixed number of retries (as the duration of the
    D-Bus call is not very reliable).
  * virt-subproc/adt-virt-ssh: Don't try to exit the ssh muxer if we don't
    have a ssh command yet. This happens when the setup script fails to open
    the testbed.

 -- Martin Pitt <email address hidden> Fri, 13 Feb 2015 12:55:29 +0100