User is unable to add more than one logical intfs on a openvswitch

[Vedamurthy Joshi]

R2.1 26 Ubuntu 14.04 multi-node setup

From Contrail UI, i added a openvswitch with one physical intf "ovstap1" and logical intf "ovstap1lif" in a VN vn1 with no vlan-id mentioned.
Then, when i try to add a second interface "ovstap2" and "ovstap2lif" in the same VN with no vlan-id, I get a "Forbidden" error
saying "Vlan tag already used in another interface : <UUID>", where UUID is the VMI of ovstap1lif

This is incorrect

[Vedamurthy Joshi (vedujoshi)]

Adding attachment

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/7299
Committed: http://github.org/Juniper/contrail-controller/commit/34d1d2ddfa3120d0c234334b8fd46c44b3842239
Submitter: Zuul
Branch: R2.1

commit 34d1d2ddfa3120d0c234334b8fd46c44b3842239
Author: Hari <email address hidden>
Date: Wed Feb 11 01:13:55 2015 -0800

The check for duplicate VLAN ids should be retricted to the logical
interfaces on the same physical interface. Adding this check.
Closes-bug: 1420418

Change-Id: I768c7ea89b0f46c97d37bd9d500b36904b505d3b

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/7463
Committed: http://github.org/Juniper/contrail-controller/commit/a9f90b4857b78c121ffdc2592efb23b4f78ef448
Submitter: Zuul
Branch: master

commit a9f90b4857b78c121ffdc2592efb23b4f78ef448
Author: Praveen K V <email address hidden>
Date: Thu Jan 29 00:43:29 2015 +0530

Merge following commits from R2.1 branch.

Dont allocate nh-index 0

nh-index 0 is reserved by vrouter. So, pre-allocate the first index so that nh
added by agent use index 1 and above

Change-Id: Ieed6d8666fc45399a51b280f1aae075425cee52c
(cherry picked from commit 3f2005b4c7be556cfdec9929b33b330ecc6ade3a)

Problem: TOR path not deleted on VRF delete.
When VRF is deleted in TSN mode, notification is received for physical_device_vn
entry.This entry contain vn_entry which can in turn can be used to extract VRF.
Multicast handler on adding the entry puts a state where it adds the VRF
entry name so that it can be used at the time of deletion because when VRF is
deleted vn_entry from physical_device_vn may not contain any VRF.
Issue was that search for multicast object was being done using vrf from VN
at time of delete. This should be done using the vrf_name stored in state.
Fixed the same here. Along with this fix also added a check to verify VRF is
in deleted state when IsTorDeleted being calculated.
Closes-bug: #1416808

Change-Id: Ica526b736a07723db40c6bb31a2f91f756cb1373
(cherry picked from commit 84347759dde36c758f37f4d12a7540de97786dbd)

Remove forwarding mode setting using IPAM gateway attributes.

Though it allows 0.0.0.0 gateway but it is not used for
forwarding mode.
Partial-Bug: #1415014

Change-Id: I72c2a3faf3ededfdd05c677d06ce654b8798618f
(cherry picked from commit 78bae98b52173a754669168478cd2c4151955f8c)

DNS disable knob : when DNS server is given as 0.0.0.0 in the dns_servers
field for the subnet or in the DHCP options list, vrouter doesnt provide
DNS proxy function any more. Do not send DNS server or DNS domain options
in DHCP response in such a case.

When there is any DNS server specified in the DHCP options list, do not
add the vrouter DNS server address any more.

If the DNS server in IPAM subnet config comes unspecified, set it to be
the same as the GW address.

Change-Id: If3e66bcfd7c137064de1471cc515e4742ea14b73
Fixes-Bug: 1416711
(cherry picked from commit 2a0d85dc4cc521e8c417182eedebe14dc9b4848b)

Conflicts:

 src/vnsw/agent/oper/vn.cc

Fix the VLAN-ID comparison in logical interface

Added checks for following,

1. VLAN-ID is not reused on multiple logical-ports on a single
physical-port
2. VLAN-ID must be set during creation of logical-interface
3. Do not allow change of vlan-id after logical-interface is
created
4. Rename interface_object to li_object to avoid confusion in
_check_interface_name

Closes-Bug: #1416323
Change-Id: I444f83d8cf8d34a6848026fe3fd0b8e23a7798f4
(cherry picked from commit 0a778eb1dab3e94c94cf0a37f36ad30f593c4e3b)

Adding 10Sec delay for ovsdb session to start txn

Issue:
------
On reconnect TOR Agent use to start the audit process immediately
causing all the previouslt installed entries to get delete as
stale, then re-added on config availabilty

Fix:
----
For R2.1, on connection ...