[Ubuntu 14.04] Failed to build an iso. We shouldn't install fence-agents on master nodes

[Alexander Kurenyshev]

Tried to build an ISO, but got a fail.
In the log there is: Error: Could not update: Could not find package fence-agents

See all log here http://jenkins-product.srt.mirantis.net:8080/view/custom_iso/job/custom_trusty_6.1_iso/13/consoleFull

[Alexei Sheplyakov (asheplyakov)]

Recently a new package fence-agents-all (version 4.0.7) has been added to the OSCI yum repo.
This package provides and obsoletes fence-agents version <= 3.1.13. Due to a poor integration
of puppet with package management tools installing fence-agents with puppet fails:

Debug: Package[fence-agents](provider=yum): Ensuring => latest
Debug: Executing '/usr/bin/yum -d 0 -e 0 -y install fence-agents'
Debug: Executing '/bin/rpm -q fence-agents --nosignature --nodigest --qf %{NAME} %|EPOCH?{%{EPOCH}}:{0}| %{VERSION} %{RELEASE} %{ARCH} :DESC: %%{SUMMARY}\n'
Error: Could not update: Could not find package fence-agents

puppet does not try to figure out if fence-agents is provided by a different package and query the status of that package, hence the error

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/154371

[Matthew Mosesohn (raytrac3r)]

That is correct. Puppet's rpm/yum package provider poorly handles meta packages and instances where a package name is obsoleted. We should avoid renaming packages when possible, but if we must, we need to amend Puppet manifests to reflect the new package name. Alexei's patch addresses this.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Alexei Sheplyakov (<email address hidden>) on branch: master
Review: https://review.openstack.org/154371
Reason: The package causing the problem has been removed from the RPM mirrors