Enhance IpRouteCommand class to support IPv6 routes.

Bug #1419805 reported by Sridhar Gaddam
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Undecided
Brian Haley

Bug Description

Current implementation of IpRouteCommand class in neutron/agent/linux/ip_lib.py needs enhancement to support IPv6 routes.

Tags: ipv6
Changed in neutron:
assignee: nobody → Sridhar Gaddam (sridhargaddam)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/154451

tags: added: ipv6
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/157555

Changed in neutron:
assignee: Sridhar Gaddam (sridhargaddam) → Brian Haley (brian-haley)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by Sridhar Gaddam (<email address hidden>) on branch: master
Review: https://review.openstack.org/154451
Reason: Abandoning in favor of the following patch - https://review.openstack.org/#/c/157555/3

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/157555
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=b9e02f22ef20c2080e95b582694063165e920b66
Submitter: Jenkins
Branch: master

commit b9e02f22ef20c2080e95b582694063165e920b66
Author: Brian Haley <email address hidden>
Date: Thu Feb 19 14:50:43 2015 -0500

    Change linux/ip_lib code to better handle address families

    The code in linux/ip_lib doesn't handle IP address families
    similarly amongst all its APIs. It also doesn't consistently
    handle how it passes options and arguments along to /sbin/ip

    So in the spirit of re-factoring, let's try and fix that:

    1. Have the code determine the IP address family from its
       arguments, given that it was passed an IP address.

    2. Always follow an (options, command, arguments) style.
       Options need a '-' prepended and go first, followed by the
       command, and finally by any arguments.

    3. In cases where we can't infer an address family but need
       one it is now required (e.g. listing routes).

    I also cleaned-up the IpRule class to fall in line with the
    other classes.

    Change-Id: Idcb9af698e3ea2d99a6a281c86fa13f51499b628
    Closes-Bug: #1419805

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
milestone: none → kilo-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: kilo-3 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.