heat engine fail to stop RPC service gracefully

Bug #1419693 reported by Kanagaraj Manickam
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Undecided
Kanagaraj Manickam

Bug Description

In heat/engine/service.py, stop() is executed when the engine is being stopped. Below code raise exception as self.conn is not defined in code.

        # Stop rpc connection at first for preventing new requests
        LOG.info(_LI("Attempting to stop engine service..."))
        try:
            self.conn.close() <<<<<< --- self.conn is not defined one
        except Exception:
            pass

So this bug is filed to correct this block so that RPC service will stop and quit peacefully.

Changed in heat:
assignee: nobody → Kanagaraj Manickam (kanagaraj-manickam)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/156118

Changed in heat:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/156118
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=5856a377d1b376c0a090712a9055dece78b29d5e
Submitter: Jenkins
Branch: master

commit 5856a377d1b376c0a090712a9055dece78b29d5e
Author: Kanagaraj Manickam <email address hidden>
Date: Mon Feb 16 09:58:20 2015 +0530

    Stop RPC server gracefully

    When engine service is stopped, this patch makes
    RPC server to get stopped gracefully.

    Change-Id: Id09ab95a574a63ee2ddb30ecc828b9820409a18f
    Closes-bug: #1419693

Changed in heat:
status: In Progress → Fix Committed
Steven Hardy (shardy)
tags: added: juno-backport-potential
Thierry Carrez (ttx)
Changed in heat:
milestone: none → kilo-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: kilo-3 → 2015.1.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/246163

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on heat (stable/juno)

Change abandoned by Jeremy Stanley (<email address hidden>) on branch: stable/juno
Review: https://review.openstack.org/246163
Reason: I'm abandoning this change in preparation for deleting the stable/juno branch, which is now at end of life.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.