HTTPInternalServerError if 'label' is missing in request body of create tenant network API

Bug #1419629 reported by Ghanshyam Mann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Ghanshyam Mann

Bug Description

Create tenant network API expect 'label' of network as one of the input. If that is missing from request body then, 500 error code is returned.

This is not appropriate error code in above case, user should get bad request error for better error handling .

Also there is no negative tests present to cover above case.

Changed in nova:
assignee: nobody → Ghanshyam Mann (ghanshyammann)
Changed in nova:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/153142
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=e87072cf2b119aac6945812aa2a8ada72cdf5a8c
Submitter: Jenkins
Branch: master

commit e87072cf2b119aac6945812aa2a8ada72cdf5a8c
Author: ghanshyam <email address hidden>
Date: Fri Feb 6 09:40:45 2015 +0900

    Raise bad request for missing 'label' in tenant network

    While creating tenant network if 'label' is missing in
    request body then, HTTPInternalServerError gets raised.

    This patch handle above case and raise HTTPBadRequest for better
    error handling.

    Closes-Bug: #1419629

    Change-Id: Ifd5c21257c10a93622fb2c94a0dc0986fefaf5d8

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → kilo-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: kilo-3 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.