Issues with clearing routers in OSTF tests

[Sebastian Kalinowski]

When running OSTF tests with Neutron network there are errors appearing in ostf log:

2015-02-06 13:20:53 DEBUG (neutronmanager) Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/fuel_health/neutronmanager.py", line 124, in _clear_networks
    cls._remove_router(router, cls.routers[router])
TypeError: unbound method _remove_router() must be called with TestNeutron instance as first argument (got unicode instance instead)

2015-02-06 13:20:53 DEBUG (neutronmanager) Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/fuel_health/neutronmanager.py", line 131, in _clear_networks
    cls._remove_subnet(subnet)
TypeError: unbound method _remove_subnet() must be called with TestNeutron instance as first argument (got dict instance instead)

2015-02-06 13:20:53 DEBUG (neutronmanager) Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/fuel_health/neutronmanager.py", line 138, in _clear_networks
    cls._remove_network(network)
TypeError: unbound method _remove_network() must be called with TestNeutron instance as first argument (got dict instance instead)

This is because wrong this _clear_network [1] which is a classmethod calls instance methods [2]. This may cause to pollute environment with routers, networks and subntes created in OSTF tests.

[1] https://github.com/stackforge/fuel-ostf/blob/6c046b69d29021524906109f18092363505ee222/fuel_health/neutronmanager.py#L119-L120
[2] https://github.com/stackforge/fuel-ostf/blob/6c046b69d29021524906109f18092363505ee222/fuel_health/neutronmanager.py#L104-L117

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/168322

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/168322
Committed: https://git.openstack.org/cgit/stackforge/fuel-ostf/commit/?id=e59c905566ed701117d7c643b435b13e6b5f8c3b
Submitter: Jenkins
Branch: master

commit e59c905566ed701117d7c643b435b13e6b5f8c3b
Author: Tatyana Leontovich <email address hidden>
Date: Fri Mar 27 14:42:35 2015 +0200

    Add teardown into neutron manager

    Add teardown into neutron manager

    Change-Id: Icb1fec7f08029f70c5d101df78c9bb0d3e56b720
    Closes-Bug: #1419025

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/6.0
Review: https://review.openstack.org/168377

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/168377
Committed: https://git.openstack.org/cgit/stackforge/fuel-ostf/commit/?id=57c4e560b8426ce51ce3f992b16a55e792989d94
Submitter: Jenkins
Branch: stable/6.0

commit 57c4e560b8426ce51ce3f992b16a55e792989d94
Author: Tatyana Leontovich <email address hidden>
Date: Fri Mar 27 14:42:35 2015 +0200

    [stable/6.0]Add teardown into neutron manager

    Add teardown into neutron manager

    Change-Id: Icb1fec7f08029f70c5d101df78c9bb0d3e56b720
    Closes-Bug: #1419025
    (cherry picked from commit e59c905566ed701117d7c643b435b13e6b5f8c3b)

[Tatyanka (tatyana-leontovich)]

verified on iso 329