Mir

Mir is not building in trusty

Bug #1418962 reported by Marco Trevisan (Treviño) on 2015-02-06

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Mir	Won't Fix	Medium	Mir development team
	mir (Ubuntu)	New	Undecided	Unassigned

Bug Description

Trying to compile mir in trusty, using gcc-4.8 fails, mostly due to the initialization lists with curly brackets.

Attached patch fixes them, but them I'm getting a weird linking issue (not happening with clang), that I wasn't experiencing some weeks ago (when the demo shell was in examples I think):

[100%] Built target mirserver
Linking CXX executable ../../bin/.mir_proving_server-uninstalled
CMakeFiles/mir_proving_server.dir/demo_shell.cpp.o: in function "mir::DefaultServerConfiguration::~DefaultServerConfiguration()":
/home/marco/Dev/mir-ports/mir/src/include/server/mir/default_server_configuration.h:159: invalid reference to "vtable for mir::DefaultServerConfiguration"
/home/marco/Dev/mir-ports/mir/src/include/server/mir/default_server_configuration.h:159: invalid reference to "vtable for mir::DefaultServerConfiguration"
collect2: error: ld returned 1 exit status

Installing the rest (libs, example clients, example servers) works as expected.

Tags:

Related branches

lp:~3v1n0/mir/compilation-fixes-trusty

Merged into lp:mir at revision 2309

PS Jenkins bot (community): Approve (continuous-integration) on 2015-02-10

Alexandros Frantzis (community): Approve on 2015-02-09

Alan Griffiths: Approve on 2015-02-09

Daniel van Vugt: Approve on 2015-02-06

lp:~vanvugt/mir/revive-trusty

Rejected for merging into lp:mir

Alan Griffiths: Disapprove on 2015-02-18

PS Jenkins bot (community): Approve (continuous-integration) on 2015-02-18

Robert Carr (community): Abstain on 2015-02-17

Alexandros Frantzis (community): Needs Fixing on 2015-02-17

Chris Halse Rogers: Needs Information on 2015-02-16

Marco Trevisan (Treviño): Pending requested 2015-02-16

Revision history for this message

Marco Trevisan (Treviño) (3v1n0) wrote on 2015-02-06:

gcc-4.8-fixes.patch Edit (2.7 KiB, text/plain)

Daniel van Vugt (vanvugt) on 2015-02-06

Changed in mir:
assignee:	nobody → Marco Trevisan (Treviño) (3v1n0)
status:	Triaged → In Progress
milestone:	none → 0.12.0

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-02-10:

Fix committed into lp:mir at revision None, scheduled for release in mir, milestone 0.12.0

Changed in mir:
status:	In Progress → Fix Committed

Revision history for this message

Ubuntu Foundations Team Bug Bot (crichton) wrote on 2015-02-10:

The attachment "gcc-4.8-fixes.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags:

added: patch

Daniel van Vugt (vanvugt) on 2015-02-11

Changed in mir:
importance:	Undecided → Medium

Daniel van Vugt (vanvugt) on 2015-02-16

Changed in mir:
status:	Fix Committed → In Progress
assignee:	Marco Trevisan (Treviño) (3v1n0) → Mir development team (mir-team)

Revision history for this message

Daniel van Vugt (vanvugt) wrote on 2015-02-19:

Won't fix. Overnight it seems the team has decided to move to C++14 instead.

Changed in mir:
status:	In Progress → Won't Fix
milestone:	0.12.0 → none

Revision history for this message

Alan Griffiths (alan-griffiths) wrote on 2015-02-19:

There are a number of reasons for not fixing and "the team has decided to move to C++14 instead" is not one of them.

Trusty has out of date versions of a number of build dependencies: android headers, gmock and g++ all cause problems. There are also binary compatibility issues between g++4.8 and g++4.9 (which led to distro fixing Mir and relating projects to g++4.9 - which we know will cause problems).

We've accepted some workarounds for bugs in g++4.8 that got fixed in 4.9 (and clang) but we don't want to get into supporting old versions of dependencies that we are not set up to test properly.

It is possible to install g++4.9 on trusty, which solves both bugs in 4.8 and allows for use of C++14:

https://launchpad.net/~ubuntu-toolchain-r/+archive/ubuntu/test?field.series_filter=trusty