OSTF connectivity test fails due to regression in code

[Vladimir Kuklin]

{"build_id": "2015-02-05_14-28-29", "ostf_sha": "2d6e8f110379807eb99e8f2a13a1d271bd1aa7bd", "build_number": "99", "release_versions": {"2014.2-6.1": {"VERSION": {"build_id": "2015-02-05_14-28-29", "ostf_sha": "2d6e8f110379807eb99e8f2a13a1d271bd1aa7bd", "build_number": "99", "api": "1.0", "nailgun_sha": "d6c6d63600e3b36606be332b23a0c5490a00fbcf", "production": "docker", "python-fuelclient_sha": "521c2491f7f04f31d8c85db68499cd193d4904e3", "astute_sha": "cf25925680814745facc7ffaf1e0b08eed6f9cb5", "feature_groups": ["mirantis"], "release": "6.1", "fuelmain_sha": "", "fuellib_sha": "bc99ea769cd67121f91f49c48dffca58e3f53fdf"}}}, "auth_required": true, "api": "1.0", "nailgun_sha": "d6c6d63600e3b36606be332b23a0c5490a00fbcf", "production": "docker", "python-fuelclient_sha": "521c2491f7f04f31d8c85db68499cd193d4904e3", "astute_sha": "cf25925680814745facc7ffaf1e0b08eed6f9cb5", "feature_groups": ["mirantis"], "release": "6.1", "fuelmain_sha": "", "fuellib_sha": "bc99ea769cd67121f91f49c48dffca58e3f53fdf"}

This commit https://review.openstack.org/#/c/152178/ introduced regression as it fails for neutron case as there is no nova-network services.

Here is what we can see in ostf logs:

urllib3.connectionpool: DEBUG: "GET http://10.108.62.2:8774/v2/bb7b26cd6261431dac2024e5d5dd4f85/os-services HTTP/1.1" 200 1091
fuel_health.nmanager: DEBUG: Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/fuel_health/nmanager.py", line 713, in ping
    host = viaHost or find_network_host()
  File "/usr/lib/python2.6/site-packages/fuel_health/nmanager.py", line 705, in find_network_host
    services)[0]
IndexError: list index out of range

fuel_health.common.test_mixins: DEBUG: Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/fuel_health/common/test_mixins.py", line 179, in verify
    result = func(*args, **kwargs)
  File "/usr/lib/python2.6/site-packages/fuel_health/nmanager.py", line 746, in _check_connectivity_from_vm
    viaHost=viaHost),
  File "/usr/lib/python2.6/site-packages/fuel_health/nmanager.py", line 733, in _ping_ip_address_from_instance
    return fuel_health.test.call_until_true(ping, 40, 1)
  File "/usr/lib/python2.6/site-packages/fuel_health/test.py", line 63, in call_until_true
    elif func():
  File "/usr/lib/python2.6/site-packages/fuel_health/nmanager.py", line 726, in ping
    ssh.exec_command_on_vm,
UnboundLocalError: local variable 'ssh' referenced before assignment

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/153348

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/153348
Committed: https://git.openstack.org/cgit/stackforge/fuel-ostf/commit/?id=6c046b69d29021524906109f18092363505ee222
Submitter: Jenkins
Branch: master

commit 6c046b69d29021524906109f18092363505ee222
Author: Vladimir Kuklin <email address hidden>
Date: Thu Feb 5 22:38:18 2015 +0300

    Search for nova-network host only with nova-network

    Search for network host only with nova-network enabled
    Otherwise, you will get an empty list and OSTF test will
    fail

    Change-Id: I1b7cb2965824e57c4421d9825550153f8cfe255a
    Closes-bug: #1418703

[Artem Panchenko (apanchenko-8)]

verified on iso #101

  feature_groups:
    - mirantis
  production: "docker"
  release: "6.1"
  api: "1.0"
  build_number: "101"
  build_id: "2015-02-05_22-55-01"
  nailgun_sha: "d6c6d63600e3b36606be332b23a0c5490a00fbcf"
  python-fuelclient_sha: "521c2491f7f04f31d8c85db68499cd193d4904e3"
  astute_sha: "cf25925680814745facc7ffaf1e0b08eed6f9cb5"
  fuellib_sha: "bc99ea769cd67121f91f49c48dffca58e3f53fdf"
  ostf_sha: "6c046b69d29021524906109f18092363505ee222"
  fuelmain_sha: ""