Exception error breaks HNAS driver loading

[Erlon R. Cruz]

When the config file is not found or if the config file has parsing errors, the driver will not load and throw the following message:

2015-02-05 14:35:31.058 DEBUG cinder.volume.manager [-] Cinder Volume DB check: vol_db_empty=True from (pid=29617) __init__ /opt/stack/cinder/cinder/volume/manager.py:189
2015-02-05 14:35:31.073 CRITICAL cinder [-] TypeError: __init__() takes at most 2 arguments (3 given)

2015-02-05 14:35:31.073 TRACE cinder Traceback (most recent call last):
2015-02-05 14:35:31.073 TRACE cinder File "/usr/local/bin/cinder-volume", line 9, in <module>
2015-02-05 14:35:31.073 TRACE cinder load_entry_point('cinder==2015.1.dev2', 'console_scripts', 'cinder-volume')()
2015-02-05 14:35:31.073 TRACE cinder File "/opt/stack/cinder/cinder/cmd/volume.py", line 69, in main
2015-02-05 14:35:31.073 TRACE cinder binary='cinder-volume')
2015-02-05 14:35:31.073 TRACE cinder File "/opt/stack/cinder/cinder/service.py", line 243, in create
2015-02-05 14:35:31.073 TRACE cinder service_name=service_name)
2015-02-05 14:35:31.073 TRACE cinder File "/opt/stack/cinder/cinder/service.py", line 127, in __init__
2015-02-05 14:35:31.073 TRACE cinder *args, **kwargs)
2015-02-05 14:35:31.073 TRACE cinder File "/opt/stack/cinder/cinder/volume/manager.py", line 196, in __init__
2015-02-05 14:35:31.073 TRACE cinder is_vol_db_empty=vol_db_empty)
2015-02-05 14:35:31.073 TRACE cinder File "/usr/local/lib/python2.7/dist-packages/oslo_utils/importutils.py", line 38, in import_object
2015-02-05 14:35:31.073 TRACE cinder return import_class(import_str)(*args, **kwargs)
2015-02-05 14:35:31.073 TRACE cinder File "/opt/stack/cinder/cinder/volume/drivers/hds/iscsi.py", line 145, in __init__
2015-02-05 14:35:31.073 TRACE cinder self.configuration.hds_hnas_iscsi_config_file)
2015-02-05 14:35:31.073 TRACE cinder File "/opt/stack/cinder/cinder/volume/drivers/hds/iscsi.py", line 93, in _read_config
2015-02-05 14:35:31.073 TRACE cinder xml_config_file)
2015-02-05 14:35:31.073 TRACE cinder TypeError: __init__() takes at most 2 arguments (3 given)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/153537

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/153537
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=c60c47f3138e551355af8418543b064a40fc32f9
Submitter: Jenkins
Branch: master

commit c60c47f3138e551355af8418543b064a40fc32f9
Author: Rodrigo Barbieri <email address hidden>
Date: Fri Feb 6 10:27:05 2015 -0200

    Fix exception error on HNAS drivers

    This patch fixes the error thrown on the loading of HNAS drivers (NFS and
    iSCSI). The bug was added by commit 450a35e2. Also, it adds unit tests to cover
    exception situations.

    Change-Id: I00957c4d39117a50d2ac2753f853841eedbe86a0
    Closes-bug: #1418645