Requests with empty body failed to parse

Bug #1418566 reported by Ekaterina Chernova
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
python-muranoclient
Fix Released
High
Ekaterina Chernova

Bug Description

If the request has application/json murano client parses body without checking it.

Need to add this missed check

Changed in python-muranoclient:
status: New → Confirmed
importance: Undecided → High
assignee: nobody → Ekaterina Chernova (efedorova)
milestone: none → 0.5.6
Revision history for this message
Radek Pospisil (radek-pospisil) wrote :

Is the "empty body" of request or response ?

Empty body of the *response* has to be also handled:

* $ murano environment-create dummy
+----------------------------------+-------+---------------------+---------------------+
| ID | Name | Created | Updated |
+----------------------------------+-------+---------------------+---------------------+
| db98819a639b4235b401763c3f8c3d81 | dummy | 2015-02-25T09:21:38 | 2015-02-25T09:21:38 |
+----------------------------------+-------+---------------------+---------------------+

* $ murano service-show db98819a639b4235b401763c3f8c3d81 /
'list' object has no attribute 'items'

The reason is that muranoclient/common/http.py json_request(..) return None on the empty list of env's services.

Changed in python-muranoclient:
status: Confirmed → In Progress
Changed in python-muranoclient:
status: In Progress → Fix Committed
Changed in python-muranoclient:
status: Fix Committed → Fix Released
tags: added: juno-backport-potential
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.