Runtime Error in tests

[Sam Betts]

Intermittently I see RuntimeErrors in the test logs, this doesn't not cause the tests to fail but might point to a deeper issue.

..Exception RuntimeError: 'maximum recursion depth exceeded while calling a Python object' in <function remove at 0x8a723e4> ignored
Exception RuntimeError: 'maximum recursion depth exceeded while calling a Python object' in <_ctypes.DictRemover object at 0x1538e4a0> ignored
.....

[Wu Wenxiang (wu-wenxiang)]

Yes, I also met this issue. Re-run could work around.
Maybe hard to dig more, I'll have a try

[Sam Betts (sambetts)]

I have put a little bit of work into debugging this as I'm seeing it v.regularly now, and have worked it down to a deepcopy of one of the test data elements. I'm not sure how we can solve this, googling python deepcopy seems to show that there might be issues if there are circular references or the object it is trying to copy is too large, this might point to a deeper issue with our tests.

It is possible to increase the recursion limit via the sys library, its default is 1000. However that is more of a band-aid than a fix.

This is the file that was ultimately throwing the issue for me after I tracked it through the code base from the test:
openstack_dashboard/test/test_data/sahara_data.py Line 37

[Wu Wenxiang (wu-wenxiang)]

Thanks Sam

As checked from history, I found https://bugs.launchpad.net/horizon/+bug/1184542.
We could do not use deepcopy, in order to avoid this issue.

And here, I found we didn't have to use deepcopy either.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/157284

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/157284
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=217a17a7f457e2895f41b9ac48c445c8dcce4197
Submitter: Jenkins
Branch: master

commit 217a17a7f457e2895f41b9ac48c445c8dcce4197
Author: Wu Wenxiang <[e-mail]>
Date: Thu Feb 19 15:31:43 2015 +0800

    Remove useless deepcopy to avoid Maximum Recursion Error

    Remove copy.deepcopy in file:
    openstack_dashboard/test/test_data/sahara_data.py

    Change-Id: I4d942ade96cf06940a0bf084a2587a6f1b4b79fd
    Closes-Bug: #1418523