Glance Client

Redundant FakeSchemaAPI __init__ method

Bug #1418508 reported by Kamil Rykowski
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance Client
Fix Released
Low
Kamil Rykowski
Glance Client 1.0.0 "1.0.0"
Nominated for Kilo by Erno Kuvaja

Bug Description

Currently, the FakeSchemaAPI in tests/utils has an overriden __init__ method which simply calls super of FakeAPI and doesn't perform any extra operations. This is redundant, because same effect will be achieved when __init__ definition is omitted in FakeSchemaAPI. Additionally it uses 'cls' as first param instead of 'self' which breaks naming convention.

Ian Cordasco (icordasc)
Changed in python-glanceclient:
status: New → Triaged
importance: Undecided → Low
assignee: nobody → Kamil Rykowski (kamil-rykowski)
Kamil Rykowski (kamil-rykowski)
Changed in python-glanceclient:
status: Triaged → In Progress
Revision history for this message
Kamil Rykowski (kamil-rykowski) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/153202

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-glanceclient (master)

Reviewed: https://review.openstack.org/153202
Committed: https://git.openstack.org/cgit/openstack/python-glanceclient/commit/?id=13b5a5ade126b39c683f3f81968b9350fc0f6ba2
Submitter: Jenkins
Branch: master

commit 13b5a5ade126b39c683f3f81968b9350fc0f6ba2
Author: Kamil Rykowski <email address hidden>
Date: Thu Feb 5 12:56:00 2015 +0100

    Remove redundant FakeSchemaAPI __init__ method

    Currently, the FakeSchemaAPI in tests/utils has an overriden __init__
    method which simply calls super of FakeAPI and doesn't perform any extra
    operations. This is redundant, because same effect will be achieved when
    __init__ definition is omitted in FakeSchemaAPI. Additionally it uses
    'cls' as first param instead of 'self' which breaks naming convention.

    Change-Id: I3e72adfbc7b67076748f640d74507ff28c6060d7
    Closes-Bug: 1418508

Changed in python-glanceclient:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-glanceclient (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/199540

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-glanceclient (stable/kilo)

Change abandoned by Erno Kuvaja (<email address hidden>) on branch: stable/kilo
Review: https://review.openstack.org/199540
Reason: Does not meet the backport requirements.

Doug Hellmann (doug-hellmann)
Changed in python-glanceclient:
milestone: none → 1.0.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.