wrong import of contrib module from novaclient

[Andriy Kurilin]

Module openstackclient.compute.client has a direct import of novaclient.v1_1.contrib.list_extensions[*]. This import produces a blocker for novaclient.

[*] - https://github.com/openstack/python-openstackclient/blob/master/openstackclient/compute/client.py#L19

[Terry Howe (thowe-g)]

What do you propose as an alternative?

[Andriy Kurilin (andreykurilin)]

I will do a patch in near future(30-60 Minutes) :)

[Andriy Kurilin (andreykurilin)]

Proposed fix: https://review.openstack.org/152919

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/152919

[Dean Troyer (dtroyer)]

I proposed https://review.openstack.org/#/c/160473/ as an alternative fix for this bug. It handles all three occurrences of direct imports into novaclient and relies on novaclient to do the version to class mapping.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/160473
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=5d92fc0d0a7c606fdcf7a3565801ae361389d9ab
Submitter: Jenkins
Branch: master

commit 5d92fc0d0a7c606fdcf7a3565801ae361389d9ab
Author: Dean Troyer <email address hidden>
Date: Mon Mar 2 13:49:40 2015 -0600

    Handle novaclient >2.20.0

    As of 2.21.0 novaclient moved all of the v1_1 classes to v2 with a
    deprecation warning. The version-non-specific interfaces provided in
    novaclient.client are insufficient to support a few specific commands in
    OSC so we need to conditionally import directly from the correct classes.

    Closes-Bug: #1418024
    Change-Id: I864b1908737803069dc1419c9cbca391b985c932

[OpenStack Infra (hudson-openstack)]

Change abandoned by Andrey Kurilin (<email address hidden>) on branch: master
Review: https://review.openstack.org/152919
Reason: already fixed by https://review.openstack.org/#/c/160473/